fix: Add reconnection to known peers #1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredcarle
force-pushed
the
fredcarle/fix/restart-peers
branch
from
1f42c68
to
3cb29dc
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1482 +/- ##
===========================================
- Coverage 72.21% 72.20% -0.01%
===========================================
Files 185 185
Lines 18226 18238 +12
===========================================
+ Hits 13161 13168 +7
- Misses 4027 4030 +3
- Partials 1038 1040 +2
|
AndrewSisley
approved these changes
May 10, 2023
shahzadlone
reviewed
May 10, 2023
shahzadlone
approved these changes
May 10, 2023
fredcarle
force-pushed
the
fredcarle/fix/restart-peers
branch
from
3cb29dc
to
479f1d7
Compare
AndrewSisley
added a commit
that referenced
this pull request
May 15, 2023
## Relevant issue(s) Resolves #1082 ## Description Adds DB/Node Restart tests. This will be required by Lens (e.g. to make sure migrations are not lost on restart). IIRC I think this also found #1482 (fixed by Fred). --------- Co-authored-by: Fred Carle <[email protected]>
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
## Relevant issue(s) Resolves sourcenetwork#1481 ## Description Currently, we de not reconnect to known peers on restart unless the peer is defined in the config file or on the CLI command. This PR makes sure that we try to reconnect to known peers.
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
## Relevant issue(s) Resolves sourcenetwork#1082 ## Description Adds DB/Node Restart tests. This will be required by Lens (e.g. to make sure migrations are not lost on restart). IIRC I think this also found sourcenetwork#1482 (fixed by Fred). --------- Co-authored-by: Fred Carle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #1481
Description
Currently, we de not reconnect to known peers on restart unless the peer is defined in the config file or on the CLI command. This PR makes sure that we try to reconnect to known peers.
Tasks
How has this been tested?
make test shows now degradation and tested manually that peers reconnect on restart.
Specify the platform(s) on which this was tested: