refactor: Use int32 for proper gql scalar Int parsing
#1493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsimnz
added
area/query
Codecov Report
@@ Coverage Diff @@
## develop #1493 +/- ##
===========================================
+ Coverage 72.18% 72.27% +0.09%
===========================================
Files 185 185
Lines 18239 18239
===========================================
+ Hits 13165 13183 +18
+ Misses 4034 4021 -13
+ Partials 1040 1035 -5
|
shahzadlone
approved these changes
May 11, 2023
There was a problem hiding this comment.
EZPZ review. Sorry some explain stuff just merged today, you would have to resolve some conflicts, should be straightforward/easy, can also just do a bulk replace of all " int" -> " int32" on top of latest develop.
question: Could we perhaps benefit from setting the default branch to develop for the graphql-go fork: https://github.com/sourcenetwork/graphql-go
jsimnz
force-pushed
the
jsimnz/refactor/I938-gql-int32
branch
from
5deab1f
to
040a00d
Compare
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
…k#1493) Updates the graphql-go lib to [this](sourcenetwork/graphql-go@fe70855) update, which applies proper scalar Int parsing and coercing to return `int32` instead of `int`. This has *minor* downstream changes as you can see in this PR. Also had to update the explain tests @shahzadlone since it was using the filter types directly in the explain output which has now changed to `int32`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #938
Description
Updates the graphql-go lib to this update, which applies proper scalar Int parsing and coercing to return
int32instead ofint.This has minor downstream changes as you can see in this PR. Also had to update the explain tests @shahzadlone since it was using the filter types directly in the explain output which has now changed to
int32Tasks
How has this been tested?
Manually + CI
Specify the platform(s) on which this was tested: