-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Improve CLI command documentation #1505
docs: Improve CLI command documentation #1505
Conversation
Codecov ReportPatch coverage:
@@ Coverage Diff @@
## develop #1505 +/- ##
===========================================
+ Coverage 74.94% 74.95% +0.01%
===========================================
Files 203 203
Lines 21084 21091 +7
===========================================
+ Hits 15800 15807 +7
- Misses 4206 4207 +1
+ Partials 1078 1077 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
question: I noticed short descriptions ending without a period and long descriptions ending with a period, is there a reason for this inconsistency in punctuation? |
Stylistic choice |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming we agree to not have ponctuation on the short descriptions (I have no strong preferences) and that my 2 comments are resolved, changes LGTM.
016d562
to
d9c875f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with the exception of the inconsistent use of these wordsDefraDB node
and database node
.
And a question about why p2p
over P2P
.
df1b173
to
666c62c
Compare
2af9ff5
to
a26ff0d
Compare
## Relevant issue(s) Resolves sourcenetwork#1229 ## Description Updates some documentation of the of CLI commands Co-authored-by: Fred Carle <[email protected]>
Relevant issue(s)
Resolves #1229
Description
Updates some documentation of the of CLI commands
Feedback welcome on the terminology used in the CLI documentation strings
How has this been tested?
Manual