Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Improve CLI command documentation #1505

Merged

Conversation

orpheuslummis
Copy link
Contributor

Relevant issue(s)

Resolves #1229

Description

Updates some documentation of the of CLI commands

Feedback welcome on the terminology used in the CLI documentation strings

How has this been tested?

Manual

@orpheuslummis orpheuslummis added action/no-benchmark Skips the action that runs the benchmark. area/cli Related to the CLI binary labels May 16, 2023
@orpheuslummis orpheuslummis requested a review from a team May 16, 2023 00:23
@orpheuslummis orpheuslummis self-assigned this May 16, 2023
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch coverage: 74.55% and project coverage change: +0.01 🎉

Comparison is base (e907f0c) 74.94% compared to head (a03623a) 74.95%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1505      +/-   ##
===========================================
+ Coverage    74.94%   74.95%   +0.01%     
===========================================
  Files          203      203              
  Lines        21084    21091       +7     
===========================================
+ Hits         15800    15807       +7     
- Misses        4206     4207       +1     
+ Partials      1078     1077       -1     
Flag Coverage Δ
all-tests 74.95% <74.55%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cli/errors.go 13.33% <0.00%> (-0.95%) ⬇️
core/net/protocol.go 77.78% <ø> (ø)
net/dag.go 100.00% <ø> (ø)
net/peer.go 74.29% <ø> (ø)
cli/p2p_collection_add.go 22.58% <40.00%> (+2.58%) ⬆️
cli/p2p_collection_getall.go 18.42% <50.00%> (+2.20%) ⬆️
cli/p2p_collection_remove.go 22.58% <50.00%> (+2.58%) ⬆️
cli/replicator_delete.go 29.79% <50.00%> (-1.46%) ⬇️
cli/replicator_set.go 30.77% <60.00%> (+1.36%) ⬆️
cli/blocks_get.go 39.58% <100.00%> (ø)
... and 15 more

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e907f0c...a03623a. Read the comment docs.

@shahzadlone
Copy link
Member

question: I noticed short descriptions ending without a period and long descriptions ending with a period, is there a reason for this inconsistency in punctuation?

@orpheuslummis
Copy link
Contributor Author

Stylistic choice

Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming we agree to not have ponctuation on the short descriptions (I have no strong preferences) and that my 2 comments are resolved, changes LGTM.

cli/p2p_collection_remove.go Outdated Show resolved Hide resolved
cli/replicator_set.go Show resolved Hide resolved
@fredcarle fredcarle force-pushed the orpheus/docs/cli-documentation branch from 016d562 to d9c875f Compare July 14, 2023 17:09
Copy link
Member

@shahzadlone shahzadlone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the exception of the inconsistent use of these wordsDefraDB node and database node.

And a question about why p2p over P2P.

cli/p2p_collection_add.go Outdated Show resolved Hide resolved
docs/cli/defradb_client.md Show resolved Hide resolved
@fredcarle fredcarle force-pushed the orpheus/docs/cli-documentation branch 2 times, most recently from df1b173 to 666c62c Compare July 17, 2023 19:18
cli/replicator_delete.go Outdated Show resolved Hide resolved
docs/cli/defradb_client.md Show resolved Hide resolved
cli/start.go Outdated Show resolved Hide resolved
@fredcarle fredcarle force-pushed the orpheus/docs/cli-documentation branch from 2af9ff5 to a26ff0d Compare July 20, 2023 04:33
@fredcarle fredcarle merged commit 754db7d into sourcenetwork:develop Jul 21, 2023
10 checks passed
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
## Relevant issue(s)

Resolves sourcenetwork#1229

## Description

Updates some documentation of the of CLI commands

Co-authored-by: Fred Carle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/no-benchmark Skips the action that runs the benchmark. area/cli Related to the CLI binary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove date/copyright from CLI printed information
3 participants