test: Require no errors when none expected #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
area/testing
Codecov Report
@@ Coverage Diff @@
## develop #1509 +/- ##
========================================
Coverage 72.07% 72.07%
========================================
Files 185 185
Lines 18295 18295
========================================
+ Hits 13186 13187 +1
Misses 4064 4064
+ Partials 1045 1044 -1 |
Asserts here typically result in panics which confuses the logs
AndrewSisley
force-pushed
the
1207-tests-require-no-error
branch
from
d29f944
to
7a113bb
Compare
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
## Relevant issue(s) Resolves sourcenetwork#1207 ## Description Requires no errors when none expected instead of just asserting. Asserts here typically result in panics which confuses the logs and the developer looking at them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #1207
Description
Requires no errors when none expected instead of just asserting. Asserts here typically result in panics which confuses the logs and the developer looking at them.