feat: Add _keys attribute to selectNode simple explain
#1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzadlone
added
feature
tests where it makes sense to.
shahzadlone
force-pushed
the
feat/add-keys-attribute-to-select-node
branch
from
bb6e884
to
bc6e6ea
Compare
shahzadlone
force-pushed
the
feat/add-keys-attribute-to-select-node
branch
2 times, most recently
from
162ec6c
to
09361b6
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1546 +/- ##
===========================================
- Coverage 72.27% 72.25% -0.03%
===========================================
Files 185 185
Lines 18374 18379 +5
===========================================
- Hits 13280 13279 -1
- Misses 4054 4056 +2
- Partials 1040 1044 +4
|
|
bug bash result: |
shahzadlone
added a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
…work#1546) ## Relevant issue(s) Resolves sourcenetwork#1535 ## Description - Delete a dead var that confused me as if we had some `dockey` on `scanNode`. - Rename commits are unrelated and just rename vars (non-user facing, fairly internal - can be ignored). - Adds the missing `_keys` attribute that represents `selectNode` keys. - Adds testing with type join filter and keys. - Adds `selectNode` targets to assert to some previous tests where it was missed before. - Fixes previous `selectNode` target assertions to adhere to this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #1535
Description
dockeyonscanNode._keysattribute that representsselectNodekeys.selectNodetargets to assert to some previous tests where it was missed before.selectNodetarget assertions to adhere to this change.