Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Include dockey in doc exists err #1558

Merged
merged 2 commits into from
Jun 2, 2023

Conversation

AndrewSisley
Copy link
Contributor

Relevant issue(s)

Resolves #1557

Description

Includes the dockey in the doc exists err, and the doc deleted error.

Requested by partner, and was super quick to do.

@AndrewSisley AndrewSisley added feature New feature or request area/db-system Related to the core system related components of the DB action/no-benchmark Skips the action that runs the benchmark. labels Jun 2, 2023
@AndrewSisley AndrewSisley added this to the DefraDB v0.6 milestone Jun 2, 2023
@AndrewSisley AndrewSisley requested a review from a team June 2, 2023 16:58
@AndrewSisley AndrewSisley self-assigned this Jun 2, 2023
Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for taking care of this Andy!

Copy link
Member

@jsimnz jsimnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@AndrewSisley AndrewSisley merged commit a6224af into sourcenetwork:develop Jun 2, 2023
@AndrewSisley AndrewSisley deleted the 1557-dockey-in-err branch June 2, 2023 17:07
@islamaliev
Copy link
Contributor

bug bash result:
ran locally a defradb node and created the same doc twice. Got message:

{
  "errors": [
    "a document with the given dockey already exists. DocKey: bae-88b63198-7d38-5714-a9ff-21ba46374fd1"
  ],
  "data": null
}

shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
## Relevant issue(s)

Resolves sourcenetwork#1557

## Description

Includes the dockey in the doc exists err, and the doc deleted error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/no-benchmark Skips the action that runs the benchmark. area/db-system Related to the core system related components of the DB feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include dockey in ErrDocumentAlreadyExists error
4 participants