Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove duplicated peers in peerstore prefix #1678

Conversation

fredcarle
Copy link
Collaborator

Relevant issue(s)

Resolves #1260

Description

This PR changes the peerstore prefix from /peers/peers to /db/peers

How has this been tested?

manual defradb client dump

Specify the platform(s) on which this was tested:

  • MacOS

@fredcarle fredcarle added the area/p2p Related to the p2p networking system label Jul 21, 2023
@fredcarle fredcarle added this to the DefraDB v0.6 milestone Jul 21, 2023
@fredcarle fredcarle requested a review from a team July 21, 2023 04:48
@fredcarle fredcarle self-assigned this Jul 21, 2023
Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with the out of scope thought that pstore should probably be part of multistore.

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.09 🎉

Comparison is base (19024d3) 74.90% compared to head (8de86cb) 74.98%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1678      +/-   ##
===========================================
+ Coverage    74.90%   74.98%   +0.09%     
===========================================
  Files          203      203              
  Lines        21091    21091              
===========================================
+ Hits         15797    15815      +18     
+ Misses        4214     4202      -12     
+ Partials      1080     1074       -6     
Flag Coverage Δ
all-tests 74.98% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
net/node.go 86.55% <100.00%> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19024d3...8de86cb. Read the comment docs.

@fredcarle
Copy link
Collaborator Author

Approved, with the out of scope thought that pstore should probably be part of multistore.

Issue created #1680

@fredcarle fredcarle merged commit 4eb0009 into sourcenetwork:develop Jul 21, 2023
10 checks passed
@fredcarle fredcarle deleted the fredcarle/fix/I1260-peer-store-prefix branch July 21, 2023 14:08
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
## Relevant issue(s)

Resolves sourcenetwork#1260 

## Description

This PR changes the peerstore prefix from `/peers/peers` to `/db/peers`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/p2p Related to the p2p networking system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Peer store is prefixed twice with peers key
2 participants