Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dockey.go.DocKey is weird and circular and needs more work #169

Closed
AndrewSisley opened this issue Feb 2, 2022 · 0 comments · Fixed by #278
Closed

dockey.go.DocKey is weird and circular and needs more work #169

AndrewSisley opened this issue Feb 2, 2022 · 0 comments · Fixed by #278
Assignees
@AndrewSisley
Labels
area/db-system Related to the core system related components of the DB refactor This issue specific to or requires *notable* refactoring of existing codebases and components
Milestone
DefraDB v0.3

Comments

@AndrewSisley
Copy link
Contributor

Suggest making it completely internal to the file, remove the Key property and return core.DocKey from anywhere that returns/exposes it currently.
@AndrewSisley AndrewSisley added area/db-system Related to the core system related components of the DB refactor This issue specific to or requires *notable* refactoring of existing codebases and components labels Feb 2, 2022
@AndrewSisley AndrewSisley mentioned this issue Feb 2, 2022
Merged
@jsimnz jsimnz modified the milestones: DefraDB v0.2.1, DefraDB v0.3 Feb 8, 2022
@AndrewSisley AndrewSisley self-assigned this Mar 7, 2022
@AndrewSisley AndrewSisley mentioned this issue Mar 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrewSisley AndrewSisley

Labels
area/db-system Related to the core system related components of the DB refactor This issue specific to or requires *notable* refactoring of existing codebases and components
Projects
None yet
Milestone
DefraDB v0.3
Development

Successfully merging a pull request may close this issue.

refactor: Remove DataStoreKey from (public) dockey struct sourcenetwork/defradb
2 participants
@jsimnz @AndrewSisley