-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Return errors from typeJoinOne #1716
fix: Return errors from typeJoinOne #1716
Conversation
420a599
to
2c477c1
Compare
planner/type_join.go
Outdated
} | ||
|
||
// We have to reset the scan node after appending the new key-filter | ||
if err := n.subType.Init(); err != nil { | ||
log.ErrorE(n.p.ctx, "Sub-type initialization error at scan node reset", err) | ||
return doc | ||
return doc, errors.Wrap("sub-type initialization error at scan node reset", err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo: Add to errors.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorted
planner/type_join.go
Outdated
@@ -408,8 +413,7 @@ func (n *typeJoinOne) valuesPrimary(doc core.Doc) core.Doc { | |||
|
|||
// re-initialize the sub type plan | |||
if err := n.subType.Init(); err != nil { | |||
log.ErrorE(n.p.ctx, "Sub-type initialization error at scan node reset", err) | |||
return doc | |||
return doc, errors.Wrap("sub-type initialization error at scan node reset", err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo: After adding the above to errors.go
, you can use the defined error function here :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the error definition is moved to the errors.go file, all clear to merge from my point of view.
Codecov ReportPatch coverage:
@@ Coverage Diff @@
## develop #1716 +/- ##
===========================================
+ Coverage 75.37% 75.38% +0.01%
===========================================
Files 208 208
Lines 21717 21719 +2
===========================================
+ Hits 16369 16372 +3
+ Misses 4207 4206 -1
Partials 1141 1141
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
## Relevant issue(s) Resolves sourcenetwork#1711 ## Description Returns errors from typeJoinOne instead of ignoring them.
Relevant issue(s)
Resolves #1711
Description
Returns errors from typeJoinOne instead of ignoring them.
I assume this is a historical accident.