-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add transaction integration tests #175
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like the addition of the transaction tests. Added some minor changes, small architecture on the ExecQuery
funcs, and some comment/clarification on the TransactionId
stuff.
136dbac
to
3d53797
Compare
Codecov Report
@@ Coverage Diff @@
## develop #175 +/- ##
===========================================
+ Coverage 57.98% 58.20% +0.21%
===========================================
Files 91 91
Lines 8935 8986 +51
===========================================
+ Hits 5181 5230 +49
+ Misses 3194 3188 -6
- Partials 560 568 +8
|
3d53797
to
304d9fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Add ExecTransactionalQuery func * Move test decription print * Allow disabling of map store for chosen tests * Add transactional query support to test lib * Add simple txn tests
* Add ExecTransactionalQuery func * Move test decription print * Allow disabling of map store for chosen tests * Add transactional query support to test lib * Add simple txn tests
Closes #174
Is fairly important functionality and should be tested, I'm also probably reworking part of that code soon and don't want to break it :)