Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add transaction integration tests #175

Merged
merged 5 commits into from
Feb 7, 2022

Conversation

AndrewSisley
Copy link
Contributor

Closes #174

Is fairly important functionality and should be tested, I'm also probably reworking part of that code soon and don't want to break it :)

@AndrewSisley AndrewSisley added bug Something isn't working area/db-system Related to the core system related components of the DB labels Feb 3, 2022
@AndrewSisley AndrewSisley self-assigned this Feb 3, 2022
Copy link
Member

@jsimnz jsimnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the addition of the transaction tests. Added some minor changes, small architecture on the ExecQuery funcs, and some comment/clarification on the TransactionId stuff.

db/tests/utils.go Show resolved Hide resolved
db/query.go Outdated Show resolved Hide resolved
@AndrewSisley AndrewSisley force-pushed the sisley/test/I174-transaction-tests branch from 136dbac to 3d53797 Compare February 4, 2022 16:23
@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #175 (304d9fd) into develop (9d822c3) will increase coverage by 0.21%.
The diff coverage is 68.42%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #175      +/-   ##
===========================================
+ Coverage    57.98%   58.20%   +0.21%     
===========================================
  Files           91       91              
  Lines         8935     8986      +51     
===========================================
+ Hits          5181     5230      +49     
+ Misses        3194     3188       -6     
- Partials       560      568       +8     
Impacted Files Coverage Δ
db/tests/utils.go 58.57% <67.07%> (+4.50%) ⬆️
db/query.go 43.39% <76.92%> (+10.89%) ⬆️
db/collection_update.go 41.13% <0.00%> (+0.90%) ⬆️
db/txn.go 61.79% <0.00%> (+5.61%) ⬆️

@AndrewSisley AndrewSisley force-pushed the sisley/test/I174-transaction-tests branch from 3d53797 to 304d9fd Compare February 4, 2022 16:28
Copy link
Member

@jsimnz jsimnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewSisley AndrewSisley merged commit aef8173 into develop Feb 7, 2022
@AndrewSisley AndrewSisley deleted the sisley/test/I174-transaction-tests branch February 7, 2022 20:43
jsimnz pushed a commit that referenced this pull request Feb 7, 2022
* Add ExecTransactionalQuery func

* Move test decription print

* Allow disabling of map store for chosen tests

* Add transactional query support to test lib

* Add simple txn tests
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
* Add ExecTransactionalQuery func

* Move test decription print

* Allow disabling of map store for chosen tests

* Add transactional query support to test lib

* Add simple txn tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/db-system Related to the core system related components of the DB bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No tests for transactions
2 participants