-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support PatchSchema relational field kind substitution #1777
feat: Support PatchSchema relational field kind substitution #1777
Conversation
Codecov ReportPatch coverage:
@@ Coverage Diff @@
## develop #1777 +/- ##
===========================================
+ Coverage 75.78% 75.86% +0.08%
===========================================
Files 209 209
Lines 22064 22089 +25
===========================================
+ Hits 16720 16756 +36
+ Misses 4193 4185 -8
+ Partials 1151 1148 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
3675147
to
c30fa22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Awesome, with the follow up work, this will be really powerful!
Whilst currently a tiny amount of code saved, the function will soon grow, and will serve as a base pattern from which later substitutions may follow.
c30fa22
to
7e8a06c
Compare
…etwork#1777) ## Relevant issue(s) Resolves sourcenetwork#1771 ## Description Adds support for PatchSchema relational field `Kind` substitution, and the auto setting of the `Schema` property.
Relevant issue(s)
Resolves #1771
Description
Adds support for PatchSchema relational field
Kind
substitution, and the auto setting of theSchema
property.