Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support PatchSchema relational field kind substitution #1777

Merged
merged 4 commits into from
Aug 14, 2023

Conversation

AndrewSisley
Copy link
Contributor

Relevant issue(s)

Resolves #1771

Description

Adds support for PatchSchema relational field Kind substitution, and the auto setting of the Schema property.

@AndrewSisley AndrewSisley added feature New feature or request area/schema Related to the schema system action/no-benchmark Skips the action that runs the benchmark. labels Aug 11, 2023
@AndrewSisley AndrewSisley added this to the DefraDB v0.7 milestone Aug 11, 2023
@AndrewSisley AndrewSisley requested a review from a team August 11, 2023 20:13
@AndrewSisley AndrewSisley self-assigned this Aug 11, 2023
@AndrewSisley AndrewSisley changed the title feat: Add support for PatchSchema relational field kind substitution feat: Support PatchSchema relational field kind substitution Aug 11, 2023
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch coverage: 94.00% and project coverage change: +0.08% 🎉

Comparison is base (384ac4b) 75.78% compared to head (7e8a06c) 75.86%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1777      +/-   ##
===========================================
+ Coverage    75.78%   75.86%   +0.08%     
===========================================
  Files          209      209              
  Lines        22064    22089      +25     
===========================================
+ Hits         16720    16756      +36     
+ Misses        4193     4185       -8     
+ Partials      1151     1148       -3     
Flag Coverage Δ
all-tests 75.86% <94.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
db/schema.go 77.78% <93.18%> (+5.05%) ⬆️
db/errors.go 80.62% <100.00%> (+0.46%) ⬆️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 384ac4b...7e8a06c. Read the comment docs.

Copy link
Member

@jsimnz jsimnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Awesome, with the follow up work, this will be really powerful!

Whilst currently a tiny amount of code saved, the function will soon grow, and will serve as a base pattern from which later substitutions may follow.
@AndrewSisley AndrewSisley merged commit a82fad6 into sourcenetwork:develop Aug 14, 2023
12 checks passed
@AndrewSisley AndrewSisley deleted the 1771-related-kind branch August 14, 2023 20:49
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
…etwork#1777)

## Relevant issue(s)

Resolves sourcenetwork#1771

## Description

Adds support for PatchSchema relational field `Kind` substitution, and
the auto setting of the `Schema` property.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/no-benchmark Skips the action that runs the benchmark. area/schema Related to the schema system feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend PatchSchema field Kind substitution magic to foriegn relations
2 participants