test: Boost collection test coverage #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #183 +/- ##
===========================================
+ Coverage 57.01% 57.43% +0.41%
===========================================
Files 98 98
Lines 9656 9643 -13
===========================================
+ Hits 5505 5538 +33
+ Misses 3523 3491 -32
+ Partials 628 614 -14
|
jsimnz
requested changes
Feb 9, 2022
|
Prob need to rebase and make sure theres no issues, as the p2p code changes/uses some stuff here. |
Is identical to the next check - fields == 0
Sequence code does not permit this to be true, and this private function is only called with an input from that sequence code
AndrewSisley
force-pushed
the
sisley/test/I182-collection-code-cov
branch
from
8cb9e0d
to
ccc60ae
Compare
jsimnz
requested changes
Feb 9, 2022
jsimnz
approved these changes
Feb 11, 2022
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
* Remove comments * Remove unused case (unsupported type) * Add dupilcate doc creation test * Remove commented out code * Add test for non-existant schema * Add test for empty collection name * Remove impossible if-clause * Add test for collection already existing * Remove duplicate check Is identical to the next check - fields == 0 * Add tests for schema with no fields * Add test for collection with no name * Add key field tests * Remove impossible check Sequence code does not permit this to be true, and this private function is only called with an input from that sequence code * Add tests for field property validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #182
No requirement for this to be added to the release