-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add CCIP Support #1896
feat: Add CCIP Support #1896
Conversation
Codecov ReportPatch coverage:
@@ Coverage Diff @@
## develop #1896 +/- ##
===========================================
+ Coverage 70.26% 70.80% +0.54%
===========================================
Files 232 233 +1
Lines 24192 24232 +40
===========================================
+ Hits 16998 17157 +159
+ Misses 6029 5903 -126
- Partials 1165 1172 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (with my limited knowledge of ccip).
nitpick: Would like the pr title beginning with an action word to indicate some more detail. i.e. feat: Add CCIP Support
## Relevant issue(s) Resolves #1894 ## Description This PR adds an HTTP handler that enables DefraDB to act as an off-chain data oracle for smart contracts. Here is an end-to-end example of how this feature works: https://github.com/sourcenetwork/defradb-example-ccip ## Tasks - [x] I made sure the code is well commented, particularly hard-to-understand areas. - [x] I made sure the repository-held documentation is changed accordingly. - [x] I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in [tools/configs/chglog/config.yml](tools/configs/chglog/config.yml)). - [x] I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ... ## How has this been tested? Unit tests Specify the platform(s) on which this was tested: - MacOS
## Relevant issue(s) Resolves sourcenetwork#1894 ## Description This PR adds an HTTP handler that enables DefraDB to act as an off-chain data oracle for smart contracts. Here is an end-to-end example of how this feature works: https://github.com/sourcenetwork/defradb-example-ccip ## Tasks - [x] I made sure the code is well commented, particularly hard-to-understand areas. - [x] I made sure the repository-held documentation is changed accordingly. - [x] I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in [tools/configs/chglog/config.yml](tools/configs/chglog/config.yml)). - [x] I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ... ## How has this been tested? Unit tests Specify the platform(s) on which this was tested: - MacOS
Relevant issue(s)
Resolves #1894
Description
This PR adds an HTTP handler that enables DefraDB to act as an off-chain data oracle for smart contracts.
Here is an end-to-end example of how this feature works:
https://github.com/sourcenetwork/defradb-example-ccip
Tasks
How has this been tested?
Unit tests
Specify the platform(s) on which this was tested: