Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add CCIP Support #1896

Merged
merged 3 commits into from
Sep 22, 2023
Merged

feat: Add CCIP Support #1896

merged 3 commits into from
Sep 22, 2023

Conversation

nasdf
Copy link
Member

@nasdf nasdf commented Sep 18, 2023

Relevant issue(s)

Resolves #1894

Description

This PR adds an HTTP handler that enables DefraDB to act as an off-chain data oracle for smart contracts.

Here is an end-to-end example of how this feature works:
https://github.com/sourcenetwork/defradb-example-ccip

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

Unit tests

Specify the platform(s) on which this was tested:

  • MacOS

@nasdf nasdf added feature New feature or request area/api Related to the external API component labels Sep 18, 2023
@nasdf nasdf added this to the DefraDB v0.8 milestone Sep 18, 2023
@nasdf nasdf self-assigned this Sep 18, 2023
@nasdf nasdf requested a review from a team September 18, 2023 23:39
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch coverage: 90.00% and project coverage change: +0.54% 🎉

Comparison is base (b8567c2) 70.26% compared to head (56cf7dc) 70.80%.
Report is 2 commits behind head on develop.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1896      +/-   ##
===========================================
+ Coverage    70.26%   70.80%   +0.54%     
===========================================
  Files          232      233       +1     
  Lines        24192    24232      +40     
===========================================
+ Hits         16998    17157     +159     
+ Misses        6029     5903     -126     
- Partials      1165     1172       +7     
Flag Coverage Δ
all-tests 70.80% <90.00%> (+0.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
http/handler_ccip.go 88.57% <88.57%> (ø)
http/server.go 100.00% <100.00%> (+100.00%) ⬆️

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84331e9...56cf7dc. Read the comment docs.

Copy link
Member

@shahzadlone shahzadlone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (with my limited knowledge of ccip).

nitpick: Would like the pr title beginning with an action word to indicate some more detail. i.e. feat: Add CCIP Support

@nasdf nasdf changed the title feat: CCIP Support feat: Add CCIP Support Sep 22, 2023
@nasdf nasdf merged commit 9e3b4e7 into sourcenetwork:develop Sep 22, 2023
14 checks passed
@nasdf nasdf deleted the nasdf/feat/ccip branch September 22, 2023 17:37
shahzadlone pushed a commit that referenced this pull request Oct 2, 2023
## Relevant issue(s)

Resolves #1894

## Description

This PR adds an HTTP handler that enables DefraDB to act as an off-chain
data oracle for smart contracts.

Here is an end-to-end example of how this feature works:
https://github.com/sourcenetwork/defradb-example-ccip

## Tasks

- [x] I made sure the code is well commented, particularly
hard-to-understand areas.
- [x] I made sure the repository-held documentation is changed
accordingly.
- [x] I made sure the pull request title adheres to the conventional
commit style (the subset used in the project can be found in
[tools/configs/chglog/config.yml](tools/configs/chglog/config.yml)).
- [x] I made sure to discuss its limitations such as threats to
validity, vulnerability to mistake and misuse, robustness to
invalidation of assumptions, resource requirements, ...

## How has this been tested?

Unit tests

Specify the platform(s) on which this was tested:
- MacOS
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
## Relevant issue(s)

Resolves sourcenetwork#1894

## Description

This PR adds an HTTP handler that enables DefraDB to act as an off-chain
data oracle for smart contracts.

Here is an end-to-end example of how this feature works:
https://github.com/sourcenetwork/defradb-example-ccip

## Tasks

- [x] I made sure the code is well commented, particularly
hard-to-understand areas.
- [x] I made sure the repository-held documentation is changed
accordingly.
- [x] I made sure the pull request title adheres to the conventional
commit style (the subset used in the project can be found in
[tools/configs/chglog/config.yml](tools/configs/chglog/config.yml)).
- [x] I made sure to discuss its limitations such as threats to
validity, vulnerability to mistake and misuse, robustness to
invalidation of assumptions, resource requirements, ...

## How has this been tested?

Unit tests

Specify the platform(s) on which this was tested:
- MacOS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Related to the external API component feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Cross Chain Interoperability Protocol
2 participants