Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Binary install named defradb #190

Merged
merged 1 commit into from
Feb 8, 2022
Merged

fix: Binary install named defradb #190

merged 1 commit into from
Feb 8, 2022

Conversation

orpheuslummis
Copy link
Contributor

@orpheuslummis orpheuslummis commented Feb 7, 2022 •
edited
Loading

closes #189

Useful for consistency and the "Getting started" experience.

@orpheuslummis orpheuslummis added the ci/build This is issue is about the build or CI system, and the administration of it. label Feb 7, 2022
@orpheuslummis orpheuslummis self-assigned this Feb 7, 2022
@shahzadlone
Copy link
Member

LGTM

@orpheuslummis orpheuslummis merged commit 853e3d0 into develop Feb 8, 2022
@orpheuslummis orpheuslummis deleted the orpheus/fix/makefile-install branch February 8, 2022 14:18
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@orpheuslummis
fix: Installing binary using defradb name (sourcenetwork#190)
44a29bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzadlone shahzadlone shahzadlone approved these changes

Assignees

@orpheuslummis orpheuslummis

Labels
ci/build This is issue is about the build or CI system, and the administration of it.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Makefile install builds a binary named main
2 participants
@orpheuslummis @shahzadlone