fix: Node private key requires data directory #1938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…generation logic to CLI
Codecov ReportAttention:
@@ Coverage Diff @@
## develop #1938 +/- ##
===========================================
- Coverage 74.62% 74.60% -0.02%
===========================================
Files 234 234
Lines 23114 23116 +2
===========================================
- Hits 17248 17244 -4
- Misses 4681 4696 +15
+ Partials 1185 1176 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
AndrewSisley
approved these changes
Oct 10, 2023
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
## Relevant issue(s) N/A ## Description This PR adds an option to set the p2p host private key. When no key is set, a new one will be generated. This fixes various tests that had to manually set a data directory even in memory only mode. ## Tasks - [x] I made sure the code is well commented, particularly hard-to-understand areas. - [x] I made sure the repository-held documentation is changed accordingly. - [x] I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in [tools/configs/chglog/config.yml](tools/configs/chglog/config.yml)). - [x] I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ... ## How has this been tested? `make test` Manually ran in both badger and memory mode to test key generation. Specify the platform(s) on which this was tested: - MacOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
N/A
Description
This PR adds an option to set the p2p host private key. When no key is set, a new one will be generated. This fixes various tests that had to manually set a data directory even in memory only mode.
Tasks
How has this been tested?
make testManually ran in both badger and memory mode to test key generation.
Specify the platform(s) on which this was tested: