feat: Add ability to delete multiple documents, using multiple ids #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Feb 8, 2022
Codecov Report
@@ Coverage Diff @@
## develop #196 +/- ##
===========================================
+ Coverage 56.96% 57.90% +0.94%
===========================================
Files 99 99
Lines 9664 9571 -93
===========================================
+ Hits 5505 5542 +37
+ Misses 3547 3413 -134
- Partials 612 616 +4
|
|
Lets get tests on this, can just continue the same structure of tests the first PR for the delete added. |
jsimnz
requested changes
Feb 11, 2022
shahzadlone
force-pushed
the
lone/feat/delete-documents-with-multi-keys
branch
from
9158ad2
to
dbb9cf8
Compare
|
Added tests and adhered to the code review suggestion. @jsimnz |
jsimnz
approved these changes
Feb 11, 2022
shahzadlone
force-pushed
the
lone/feat/delete-documents-with-multi-keys
branch
from
dbb9cf8
to
480a000
Compare
shahzadlone
added a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
…ourcenetwork#196) ### ISSUE: Resolves sourcenetwork#164 Resolves sourcenetwork#165 ### DESCRIPTION: Adds the ability to delete multiple documents, using multiple ids. We can now delete multiple documents using multiple dockeys (i.e. ids). For example: ``` mutation { delete_user(ids: ["bae-3a1a496e-24eb-5ae3-9c17-524c146a393e" , "bae-6a6482a8-24e1-5c73-a237-ca569e41507d"]) { KeyOfDeletedDocument: _key } } ``` Gives this on successful deletion of all documents: ``` { "data": [ { "KeyOfDeletedDocument": "bae-3a1a496e-24eb-5ae3-9c17-524c146a393e" }, { "KeyOfDeletedDocument": "bae-6a6482a8-24e1-5c73-a237-ca569e41507d" } ] } ``` ### COMMITS: * feat: Add implementation for deleting multiple documents. * test: Add tests for the multiple document deletion using multiple keys. * refactor: Split tests into seperate files for the deletion mutuation command. * fix: suppress linter error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #164
Resolves #165
Adds the ability to delete multiple documents, using multiple ids.
We can now delete multiple documents using multiple dockeys (i.e. ids).
For example:
Gives this on successful deletion of all documents: