fix: Make return type for FieldKind_INT an int64 #1982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredcarle
changed the title
Codecov ReportAttention:
@@ Coverage Diff @@
## develop #1982 +/- ##
===========================================
- Coverage 74.45% 74.38% -0.08%
===========================================
Files 246 246
Lines 24306 24309 +3
===========================================
- Hits 18096 18080 -16
- Misses 5006 5026 +20
+ Partials 1204 1203 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
fredcarle
deleted the
fredcarle/fix/I1681-fix-return-type-for-FieldKind_Int
branch
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
## Relevant issue(s) Resolves sourcenetwork#1681 Resolves sourcenetwork#1981 ## Description The PR ensures the return type for `FieldKind_INT` is always of the same go type `int64`. Fixing this also surface a small bug in the indexes where a broken index should have returned an error but was returning an error for a different reason. That reason being that the expected return type was `int64` but the actual returned type was `uint64`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #1681
Resolves #1981
Description
The PR ensures the return type for
FieldKind_INTis always of the same go typeint64.Fixing this also surface a small bug in the indexes where a broken index should have returned an error but was returning an error for a different reason. That reason being that the expected return type was
int64but the actual returned type wasuint64.Tasks
How has this been tested?
(replace) Describe the tests performed to verify the changes. Provide instructions to reproduce them.
Specify the platform(s) on which this was tested: