feat: Enable playground in Docker build #1986
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## develop #1986 +/- ##
===========================================
+ Coverage 74.19% 74.20% +0.01%
===========================================
Files 246 246
Lines 24426 24426
===========================================
+ Hits 18121 18124 +3
+ Misses 5093 5091 -2
+ Partials 1212 1211 -1
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
LGTM.
question: Out of scope of this PR, but often times when I see the playground dependencies being bumped (non-go deps) I wonder if the tests or some aspect in the build would catch if a dependency broke the playground stuff. Is there a way to (if we don't already) run these tests in ci to ensure playground state isn't broken. Does this PR in anyway improve that situation?
Just an increase in size and an extra Docker build step. |
It should let us know if the playground build is failing in the Docker build workflow. It would be nice to automate a test that runs the Docker container and loads the playground. |
## Relevant issue(s) Resolves sourcenetwork#1983 ## Description This PR enables the embedded playground in the DefraDB Docker builds. ## Tasks - [x] I made sure the code is well commented, particularly hard-to-understand areas. - [x] I made sure the repository-held documentation is changed accordingly. - [x] I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in [tools/configs/chglog/config.yml](tools/configs/chglog/config.yml)). - [x] I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ... ## How has this been tested? Built and pushed image to `docker.io/sourcenetwork/defradb:develop` Specify the platform(s) on which this was tested: - MacOS
Relevant issue(s)
Resolves #1983
Description
This PR enables the embedded playground in the DefraDB Docker builds.
Tasks
How has this been tested?
Built and pushed image to
docker.io/sourcenetwork/defradb:developSpecify the platform(s) on which this was tested: