refactor: Restructure db/txn/multistore structures

[AndrewSisley]

Closes #172

• Removes the multi-store-properties declaration duplication
• Merges the two transaction interfaces and implementations
• Removes non-datastore access from transactions
• Moves Commit/Discard onto the core transaction (removed from iterable)
• Reworks the shimming of batchable => transaction stores, and removes the related code duplication in db/txn
• Reworks the shimming of (non)iterable transaction stores, and removes the related code duplication in db/txn
• DocFetcher now uses the datastore (instead of root)

[codecov]

Codecov Report

Merging #199 (79f92b4) into develop (8511a1c) will decrease coverage by 0.56%.
The diff coverage is 71.37%.

@@             Coverage Diff             @@
##           develop     #199      +/-   ##
===========================================
- Coverage    57.52%   56.96%   -0.57%     
===========================================
  Files           98       99       +1     
  Lines         9616     9664      +48     
===========================================
- Hits          5532     5505      -27     
- Misses        3463     3547      +84     
+ Partials       621      612       -9     

Impacted Files	Coverage Δ
db/blockstore.go	0.00% <0.00%> (ø)
db/schema.go	38.63% <0.00%> (ø)
db/collection_update.go	41.40% <50.00%> (ø)
db/sequence.go	65.11% <50.00%> (ø)
store/wrappedStore.go	61.29% <61.29%> (ø)
query/graphql/planner/executor.go	79.06% <66.66%> (ø)
store/txn.go	61.42% <72.72%> (+4.28%)	⬆️
db/collection_delete.go	28.07% <77.77%> (ø)
store/shimstore.go	77.77% <77.77%> (ø)
db/db.go	53.98% <82.35%> (-0.49%)	⬇️
... and 14 more

[jsimnz]

Was concerend when I initial saw the # of lines/files changed, but I can see now its mostly updating all the references to core.Txn and the utility funcs for the stores.

In general I think this is much more organized. I had a question about the Copy method, and re-implementing the namespace package.

My only comment is whether it makes more sense to have the Txn interface defined in core or client as per our convo in discord. I personally think it belongs with the rest of the interfaces in the client package.

[AndrewSisley]

Was concerend when I initial saw the # of lines/files changed, but I can see now its mostly updating all the references to core.Txn and the utility funcs for the stores.

In general I think this is much more organized. I had a question about the Copy method, and re-implementing the namespace package.

My only comment is whether it makes more sense to have the Txn interface defined in core or client as per our convo in discord. I personally think it belongs with the rest of the interfaces in the client package.

Would like to sort out the client vs core issue in #200 if alright with you?

[jsimnz]

Would like to sort out the client vs core issue in #200 if alright with you?

As you you'd prefer to merge this now as is with Txn defined in core/ then address the whole relation/naming/organization of core/ vs client/ in #200?

Thats prob fine :)

[AndrewSisley]

Would like to sort out the client vs core issue in #200 if alright with you?

As you you'd prefer to merge this now as is with Txn defined in core/ then address the whole relation/naming/organization of core/ vs client/ in #200?

Thats prob fine :)

Yeah sorry - my English was horrible in my earlier reply - would rather do it then, might get a bit involved as might want to make sure all the stuff on the Txn interface is in client too (or whatever we decide in that ticket)

[jsimnz]

After final reivew, all is good!

LGTM

[AndrewSisley]

Sweet - cheers