Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update old or missing license headers #205

Merged
merged 2 commits into from
Feb 14, 2022

Conversation

orpheuslummis
Copy link
Contributor

Some license headers were missing or not updated in the v0.2.0 release and with the inclusion of the p2p PRs, so correcting the situation here.

@orpheuslummis orpheuslummis added the documentation Improvements or additions to documentation label Feb 11, 2022
@orpheuslummis orpheuslummis self-assigned this Feb 11, 2022
@jsimnz
Copy link
Member

jsimnz commented Feb 11, 2022

Everything in the net/ package we are explicitly licensing under Apache 2, and foregoing any copyright. See the comment here in net/doc.go

defradb/net/doc.go

Lines 33 to 37 in 27db5f5

Credit: Some of the base structure of this net package and its
types is inspired/inherited from Textile Threads
(github.com/textileio/go-threads). As such, we are omitting
copyright on this "net" package and will release this folder
under the Apache 2.0 license as per the header of each file.

@jsimnz
Copy link
Member

jsimnz commented Feb 11, 2022

Does mean we need to add an Apache 2.0 license header to these files under net/

@orpheuslummis
Copy link
Contributor Author

@jsimnz please double check the APL license header

Copyright © 2022 Democratized Data Foundation

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

    http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.

@jsimnz
Copy link
Member

jsimnz commented Feb 11, 2022

I think just

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

    http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.

is fine for the net/ package

@orpheuslummis
Copy link
Contributor Author

Now the code files (not the autogenerated ones) under /net have license header APL. I included all files under /net instead of just the files of the top-level net package. If that's okay, it should be ready.

Copy link
Member

@jsimnz jsimnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@orpheuslummis orpheuslummis merged commit bbc8773 into develop Feb 14, 2022
@orpheuslummis orpheuslummis deleted the orpheus/docs/license-headers branch February 14, 2022 21:29
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants