Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Filtering on unique index if there is no match #2177

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

islamaliev
Copy link
Contributor

Relevant issue(s)

Resolves #2176

Description

Make unique index distinguish between key-not-found and other errors.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

Unit and integration tests

Specify the platform(s) on which this was tested:

  • MacOS

@islamaliev islamaliev added bug Something isn't working area/query Related to the query component labels Jan 9, 2024
@islamaliev islamaliev added this to the DefraDB v0.9 milestone Jan 9, 2024
@islamaliev islamaliev self-assigned this Jan 9, 2024
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f7a4166) 74.21% compared to head (dc819ed) 74.16%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2177      +/-   ##
===========================================
- Coverage    74.21%   74.16%   -0.06%     
===========================================
  Files          256      256              
  Lines        25366    25368       +2     
===========================================
- Hits         18825    18812      -13     
- Misses        5263     5275      +12     
- Partials      1278     1281       +3     
Flag Coverage Δ
all-tests 74.16% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
db/fetcher/indexer_iterators.go 82.84% <100.00%> (+0.78%) ⬆️

... and 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7a4166...dc819ed. Read the comment docs.

Copy link
Member

@jsimnz jsimnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@islamaliev islamaliev merged commit d2cfd87 into develop Jan 9, 2024
33 checks passed
@islamaliev islamaliev deleted the fix/no-filter-match-on-unique-index branch January 9, 2024 09:33
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Jan 22, 2024
## Relevant issue(s)

Resolves sourcenetwork#2176

## Description

Make unique index distinguish between key-not-found and other errors.
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
## Relevant issue(s)

Resolves sourcenetwork#2176

## Description

Make unique index distinguish between key-not-found and other errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/query Related to the query component bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Querying unique index with non-existant value in filter errors
2 participants