Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow setting null values on doc fields #2273

Merged

Conversation

islamaliev
Copy link
Contributor

Relevant issue(s)

Resolves #2272

Description

Allows setting of null values for nillable fields.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

Integration tests.

Specify the platform(s) on which this was tested:

  • MacOS

@islamaliev islamaliev added area/query Related to the query component area/collections Related to the collections system labels Jan 30, 2024
@islamaliev islamaliev added this to the DefraDB v0.10 milestone Jan 30, 2024
@islamaliev islamaliev self-assigned this Jan 30, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (5834f81) 74.04% compared to head (3ce2d75) 74.07%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2273      +/-   ##
===========================================
+ Coverage    74.04%   74.07%   +0.03%     
===========================================
  Files          256      256              
  Lines        25748    25761      +13     
===========================================
+ Hits         19063    19080      +17     
+ Misses        5367     5362       -5     
- Partials      1318     1319       +1     
Flag Coverage Δ
all-tests 74.07% <78.26%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
client/ctype.go 93.10% <100.00%> (ø)
core/encoding.go 64.23% <100.00%> (ø)
merkle/crdt/merklecrdt.go 87.80% <100.00%> (ø)
planner/sum.go 88.16% <100.00%> (ø)
request/graphql/schema/collection.go 90.95% <100.00%> (+0.50%) ⬆️
client/document.go 67.85% <83.33%> (+0.25%) ⬆️
db/index.go 63.24% <50.00%> (ø)
client/descriptions.go 65.91% <42.86%> (ø)

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5834f81...3ce2d75. Read the comment docs.

Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for putting this together.

@islamaliev islamaliev merged commit 8a66721 into sourcenetwork:develop Jan 30, 2024
31 of 32 checks passed
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
## Relevant issue(s)

Resolves sourcenetwork#2272

## Description

Allows setting of null values for nillable fields.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/collections Related to the collections system area/query Related to the query component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow setting null values for doc fields
2 participants