Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove unused Delete field from client.Document #2275

Merged

Conversation

islamaliev
Copy link
Contributor

Relevant issue(s)

Resolves #2274

Description

Remove unused Delete method of client.Document

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

Unit and integration tests.

Specify the platform(s) on which this was tested:

  • MacOS

@islamaliev islamaliev added refactor This issue specific to or requires *notable* refactoring of existing codebases and components code quality Related to improving code quality labels Jan 30, 2024
@islamaliev islamaliev added this to the DefraDB v0.10 milestone Jan 30, 2024
@islamaliev islamaliev self-assigned this Jan 30, 2024
Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If we ever need this at some point we can add it back but I currently can't think of a reason do to so.

fredcarle

This comment was marked as duplicate.

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8a66721) 74.05% compared to head (cdf6772) 74.11%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2275      +/-   ##
===========================================
+ Coverage    74.05%   74.11%   +0.06%     
===========================================
  Files          256      256              
  Lines        25761    25740      -21     
===========================================
  Hits         19075    19075              
+ Misses        5366     5347      -19     
+ Partials      1320     1318       -2     
Flag Coverage Δ
all-tests 74.11% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
client/document.go 70.26% <ø> (+2.41%) ⬆️
client/value.go 93.33% <ø> (+5.10%) ⬆️

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a66721...cdf6772. Read the comment docs.

@islamaliev islamaliev merged commit cb08c18 into sourcenetwork:develop Jan 31, 2024
33 checks passed
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
…ork#2275)

## Relevant issue(s)

Resolves sourcenetwork#2274 

## Description

Remove unused `Delete` method of `client.Document`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Related to improving code quality refactor This issue specific to or requires *notable* refactoring of existing codebases and components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused Delete method from client.Document
2 participants