fix: Handle proper type conversion on sort nodes. #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsimnz
added
bug
…ncoding inconsistency
Codecov Report
@@ Coverage Diff @@
## develop #228 +/- ##
===========================================
- Coverage 57.95% 57.94% -0.01%
===========================================
Files 99 99
Lines 9636 9648 +12
===========================================
+ Hits 5585 5591 +6
- Misses 3426 3432 +6
Partials 625 625
|
| @@ -87,6 +87,20 @@ func (e EncProperty) Decode() (core.CType, interface{}, error) { | |||
| } | |||
| val = stringArray | |||
| } | |||
| } else { // CBOR often encodes values typed as floats as ints | |||
| switch e.Desc.Kind { | |||
| case base.FieldKind_FLOAT: | |||
There was a problem hiding this comment.
not sure all these cases are needed - only uint64 is hit according to codecov - it would be wierd if it used int/unit, but int64 might be due to lack of negative number testing. Happy(ier?) for them all to stay in for now, but maybe (in an ideal world with lots of free time) we could revist this
There was a problem hiding this comment.
I know at the very least it uses int64 and uint64 depending on if its a negative number. Im pretty sure I can drop the other cases.
AndrewSisley
approved these changes
Feb 24, 2022
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
* Handled CBOR encoding edge case * Fixed tests which manually casted results to uint64 due to previous encoding inconsistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #227.
This ensures that decoded values from the fetcher are consistent with respect to the float/int edge case of the CBOR encoding/decoding.