fix: Mark docs as deleted when querying in delete mut #2298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
bug
AndrewSisley
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2298 +/- ##
===========================================
+ Coverage 73.85% 73.94% +0.09%
===========================================
Files 256 256
Lines 25587 25590 +3
===========================================
+ Hits 18896 18920 +24
+ Misses 5369 5353 -16
+ Partials 1322 1317 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 14 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
shahzadlone
approved these changes
Feb 8, 2024
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
…2298) ## Relevant issue(s) Resolves sourcenetwork#1846 ## Description Marks docs as deleted when querying _deleted in delete mutation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #1846
Description
Marks docs as deleted when querying _deleted in delete mutation.
We could refetch them like we do in update queries, but that seems unnecessary for deletes (updates needs to watch out for impact on aggregates, relations, etc)