feat: Rework GetCollection/SchemaByFoo funcs into single #2319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
area/collections
AndrewSisley
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2319 +/- ##
===========================================
+ Coverage 74.29% 74.81% +0.52%
===========================================
Files 256 256
Lines 25373 25254 -119
===========================================
+ Hits 18849 18892 +43
+ Misses 5223 5076 -147
+ Partials 1301 1286 -15
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Function has been preserved as syntax sugar here, as the return type is worth it in this case I think (can only ever return one item, or an error).
Sorry about this one, collection describe was pretty broken, only respecting the get-inactive flag and none of the others, and I didn't realize until quite late. It didn't seem worth going back and re-committing everything with this fix in first.
Misc clean after fixing collection describe, I didn't want to lump this in with the actual fix.
Broken out to own commit to avoid confusing the actual concrete changes made in the next few commits.
Function preserved as syntax sugar as the return type is handy
AndrewSisley
force-pushed
the
2008-col-schema-filter-opts
branch
from
d1e0691
to
53f3f10
Compare
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
…rk#2319) ## Relevant issue(s) Resolves sourcenetwork#2008 ## Description Reworks the GetCollection/SchemaByFoo funcs into single GetCollections and GetSchemas funcs.
|
bug bash issue #2371 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #2008
Description
Reworks the GetCollection/SchemaByFoo funcs into single GetCollections and GetSchemas funcs.
Commits are mostly clean, and might be easier to review from everything at once, but watch out for a pair of small fixup commits I left in the middle (sorry).