-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Reverted order for indexed fields #2335
feat: Reverted order for indexed fields #2335
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2335 +/- ##
===========================================
+ Coverage 74.75% 75.05% +0.30%
===========================================
Files 257 266 +9
Lines 25349 25855 +506
===========================================
+ Hits 18949 19404 +455
- Misses 5103 5147 +44
- Partials 1297 1304 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is going to take a while for me to get through this one :) Submitting first chunk of comments now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pausing my review for now - there appears to be a lot of dead code, and a lot of fairly fiddly and undocumented code. It looks like you have done a great job getting it to work, but I do not think it is yet ready for review.
Can you please remove the dead code, and document the remaining. Please in the code comments focus on why what is being done is being done.
9d9d949
to
a378edd
Compare
…ead of `client.FieldValue` for encoding/decoding.
4d1f7f8
to
fa956bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the changes. I'm wondering if the encoding should eventually be applied to stored values instead of using cbor.
Approving with a few minor comments to resolve before merge.
Relevant issue(s)
Resolves #2229
Description
Enable reverted ordering for indexed fields. Which is mostly relevant to composite indexes.
This PR introduces a whole new package
encoding
. A significant part of it is taken from CocroachDB which fits well to our needs. Other encoding approaches (mostly for integers) were also consider: like fixed-length encoding, avro's zizzag encoding, base128 varints encoding and few others.