chore: Remove fmt.println from core package #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
force-pushed
the
sisley/chore/I237-core-prinln
branch
from
e4bc8ff
to
2977c03
Compare
AndrewSisley
force-pushed
the
sisley/chore/I237-core-prinln
branch
from
2977c03
to
aedd19c
Compare
Codecov Report
@@ Coverage Diff @@
## develop #238 +/- ##
===========================================
- Coverage 58.59% 58.57% -0.02%
===========================================
Files 103 103
Lines 9848 9844 -4
===========================================
- Hits 5770 5766 -4
Misses 3448 3448
Partials 630 630
|
|
As for the linter rule, perhaps via using the following https://golangci-lint.run/usage/linters/#forbidigo |
Nice, cheers |
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would probably like a linter rule to ban fmt.Print[ln] at somepoint
Were only two in document package, so a chucked them in here too