Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider banning fmt.Println* via linter rule #242

Closed
Tracked by #67
AndrewSisley opened this issue Feb 28, 2022 · 0 comments · Fixed by #253
Closed
Tracked by #67

Consider banning fmt.Println* via linter rule #242

AndrewSisley opened this issue Feb 28, 2022 · 0 comments · Fixed by #253
Assignees
@AndrewSisley
Labels
ci/build This is issue is about the build or CI system, and the administration of it.

Comments

@AndrewSisley
Copy link
Contributor

Part of #67

Ban suggested by me, discuss with whole team before merging.

Solution suggested by Orpheus:

As for the linter rule, perhaps via using the following https://golangci-lint.run/usage/linters/#forbidigo
@AndrewSisley AndrewSisley mentioned this issue Feb 28, 2022
Closed
11 tasks
@orpheuslummis orpheuslummis mentioned this issue Mar 1, 2022
Closed
@orpheuslummis orpheuslummis added the ci/build This is issue is about the build or CI system, and the administration of it. label Mar 1, 2022
@AndrewSisley AndrewSisley mentioned this issue Mar 1, 2022
Merged
@AndrewSisley AndrewSisley self-assigned this Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrewSisley AndrewSisley

Labels
ci/build This is issue is about the build or CI system, and the administration of it.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Purge all println and ban it sourcenetwork/defradb
2 participants
@orpheuslummis @AndrewSisley