refactor: Rewrite convertImmutable #2445
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2445 +/- ##
===========================================
+ Coverage 74.78% 74.84% +0.06%
===========================================
Files 268 268
Lines 25928 25927 -1
===========================================
+ Hits 19388 19403 +15
+ Misses 5206 5193 -13
+ Partials 1334 1331 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| out := make([]any, len(vals)) | ||
| for i := range vals { | ||
| if vals[i].HasValue() { | ||
| out[i] = vals[i].Value() |
There was a problem hiding this comment.
suggestion: this is a small change with potentially significant impact. I wonder why no tests cover this.
Would be great to add some tests.
There was a problem hiding this comment.
It is tested, I was mistaken in your PR - I just rewrote it because it was really ugly
There was a problem hiding this comment.
I don't think this change has any impact other than improving the efficiency of the code. The returned result is the same.
Relevant issue(s)
Resolves #2444
Description
Rewrites convertImmutable.