feat: Force explicit primary decl. in SDL for one-ones #2462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
feature
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2462 +/- ##
===========================================
+ Coverage 75.07% 75.12% +0.04%
===========================================
Files 278 278
Lines 26945 26940 -5
===========================================
+ Hits 20228 20236 +8
+ Misses 5369 5361 -8
+ Partials 1348 1343 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
AndrewSisley
changed the title
AndrewSisley
changed the title
islamaliev
approved these changes
Mar 28, 2024
I woke up this morning realising I had not done that - will add at least one before merge :) |
Will be used from the graphql package too shortly
AndrewSisley
force-pushed
the
2461-force-primary-sdl-declaration
branch
from
2bf7967
to
2fb78db
Compare
shahzadlone
pushed a commit
that referenced
this pull request
Apr 3, 2024
## Relevant issue(s) Resolves #2461 ## Description Forces the explicit declaration of the primary side of one-one relation fields in SDL. PatchSchema already forces this and needed no change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #2461
Description
Forces the explicit declaration of the primary side of one-one relation fields in SDL.
PatchSchema already forces this and needed no change.
Note: The error usage in the db package may be removed very soon in #2451 along with the entire
request/graphql/schema/relations.gofile.