-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add P Counter CRDT #2482
feat: Add P Counter CRDT #2482
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2482 +/- ##
===========================================
- Coverage 75.66% 75.59% -0.08%
===========================================
Files 291 291
Lines 28072 28086 +14
===========================================
- Hits 21240 21229 -11
- Misses 5478 5498 +20
- Partials 1354 1359 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Praise: Nice tests
Mostly questions. Looks good in first pass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just have a few minor comments
tests/integration/schema/updates/add/field/crdt/pcounter_test.go
Outdated
Show resolved
Hide resolved
c7a8713
to
916729d
Compare
916729d
to
204fdc9
Compare
Relevant issue(s)
Resolves #2116
Description
This PR adds a Positive Counter CRDT type. It converts the PNCounter implementation to a Counter implementation that supports both PN and P counters.
Tasks
How has this been tested?
make test
Specify the platform(s) on which this was tested: