Only log errors and above when benchmarking #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
bug
Codecov Report
@@ Coverage Diff @@
## develop #261 +/- ##
========================================
Coverage 58.49% 58.49%
========================================
Files 103 103
Lines 9834 9836 +2
========================================
+ Hits 5752 5754 +2
Misses 3454 3454
Partials 628 628
|
|
@shahzadlone I'm wondering if errors being outputted in benchmarking matter for #232 ? |
|
#232 is simply the comparison of benchmarks. If more errors are hit and emitted then it will likely show a hit in performance. |
|
Given this PR doesn't have a conventional commit prefix: Just remember to add the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #260
Is very easy to disable it entirely if preferred, setting the config.outputPaths to empty instead (with a couple of tweaks in the config code) - let me know