Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Race condition when testing CLI #2713

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

nasdf
Copy link
Member

@nasdf nasdf commented Jun 12, 2024

Relevant issue(s)

Resolves #2712

Description

This PR fixes a race condition found in #2700

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

make test

Specify the platform(s) on which this was tested:

  • MacOS

@nasdf nasdf added the bug Something isn't working label Jun 12, 2024
@nasdf nasdf added this to the DefraDB v0.12 milestone Jun 12, 2024
@nasdf nasdf self-assigned this Jun 12, 2024
@nasdf nasdf requested a review from a team June 12, 2024 18:53
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 94.68085% with 5 lines in your changes missing coverage. Please review.

Project coverage is 77.87%. Comparing base (d15b3b3) to head (cbee936).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2713      +/-   ##
===========================================
- Coverage    77.95%   77.87%   -0.08%     
===========================================
  Files          310      310              
  Lines        23120    23113       -7     
===========================================
- Hits         18022    17998      -24     
- Misses        3717     3728      +11     
- Partials      1381     1387       +6     
Flag Coverage Δ
all-tests 77.87% <94.68%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cli/utils.go 74.07% <100.00%> (ø)
cli/start.go 44.83% <97.87%> (-0.47%) ⬇️
cli/config.go 83.67% <75.00%> (-1.51%) ⬇️
cli/root.go 97.47% <94.74%> (-0.03%) ⬇️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d15b3b3...cbee936. Read the comment docs.

Copy link
Contributor

@islamaliev islamaliev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nasdf nasdf merged commit 4510706 into sourcenetwork:develop Jun 12, 2024
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Race condition in CLI test flags
2 participants