Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Support asserting on doc index in test results #2786

Merged

Conversation

AndrewSisley
Copy link
Contributor

Relevant issue(s)

Resolves #2785

Description

Support asserting on doc index in test results.

PR does not seek to propagate it's usage, only to permit it's usage.

How has this been tested?

I also checked that it fails correctly if the results do not pair up.

@AndrewSisley AndrewSisley added area/testing Related to any test or testing suite code quality Related to improving code quality labels Jun 27, 2024
@AndrewSisley AndrewSisley added this to the DefraDB v0.12 milestone Jun 27, 2024
@AndrewSisley AndrewSisley requested a review from a team June 27, 2024 16:05
@AndrewSisley AndrewSisley self-assigned this Jun 27, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.90%. Comparing base (2efd29a) to head (f29dc92).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2786      +/-   ##
===========================================
+ Coverage    78.77%   78.90%   +0.13%     
===========================================
  Files          315      315              
  Lines        23835    23835              
===========================================
+ Hits         18775    18807      +32     
+ Misses        3680     3659      -21     
+ Partials      1380     1369      -11     
Flag Coverage Δ
all-tests 78.90% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 16 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2efd29a...f29dc92. Read the comment docs.

Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewSisley AndrewSisley merged commit dd53c13 into sourcenetwork:develop Jun 27, 2024
38 of 39 checks passed
@AndrewSisley AndrewSisley deleted the 2785-doc-index-results branch June 27, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Related to any test or testing suite code quality Related to improving code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support test.DocIndex usage in expected results
2 participants