Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Remove duplicate test #2787

Merged

Conversation

AndrewSisley
Copy link
Contributor

Relevant issue(s)

Resolves #1854

Description

Removes a duplicate test.

I think this bug might have been resolved by the validation refactor a few weeks ago and I never spotted the test-split when tweaking the expected result.

@AndrewSisley AndrewSisley added area/testing Related to any test or testing suite code quality Related to improving code quality labels Jun 27, 2024
@AndrewSisley AndrewSisley added this to the DefraDB v0.12 milestone Jun 27, 2024
@AndrewSisley AndrewSisley requested a review from a team June 27, 2024 16:24
@AndrewSisley AndrewSisley self-assigned this Jun 27, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.83%. Comparing base (dd53c13) to head (db9dc27).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2787   +/-   ##
========================================
  Coverage    78.83%   78.83%           
========================================
  Files          315      315           
  Lines        23835    23835           
========================================
+ Hits         18788    18789    +1     
+ Misses        3670     3669    -1     
  Partials      1377     1377           
Flag Coverage Δ
all-tests 78.83% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd53c13...db9dc27. Read the comment docs.

Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think this might have been resolved by the validation refactor a few weeks ago
@AndrewSisley AndrewSisley merged commit 1a8b1fa into sourcenetwork:develop Jun 27, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Related to any test or testing suite code quality Related to improving code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Field does not exist error inconsistent
2 participants