Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove reference to client ping from readme #2793

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

AndrewSisley
Copy link
Contributor

Relevant issue(s)

Resolves #2792

Description

Removes the reference to client ping from readme. The ping command no longer exists.

How has this been tested?

Tested locally, command fails with Error: Get "http://127.0.0.1:9181/api/v0/collections": dial tcp 127.0.0.1:9181: connect: connection refused if the server is down.

@AndrewSisley AndrewSisley added documentation Improvements or additions to documentation area/cli Related to the CLI binary labels Jun 28, 2024
@AndrewSisley AndrewSisley added this to the DefraDB v0.12 milestone Jun 28, 2024
@AndrewSisley AndrewSisley requested a review from a team June 28, 2024 14:22
@AndrewSisley AndrewSisley self-assigned this Jun 28, 2024
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.82%. Comparing base (7261711) to head (3102f0c).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2793      +/-   ##
===========================================
+ Coverage    78.77%   78.82%   +0.05%     
===========================================
  Files          315      315              
  Lines        23835    23835              
===========================================
+ Hits         18775    18787      +12     
+ Misses        3679     3675       -4     
+ Partials      1381     1373       -8     
Flag Coverage Δ
all-tests 78.82% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 14 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7261711...3102f0c. Read the comment docs.

Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewSisley AndrewSisley merged commit 666e871 into sourcenetwork:develop Jun 28, 2024
39 checks passed
@AndrewSisley AndrewSisley deleted the 2792-client-ping branch June 28, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Related to the CLI binary documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README mentions defradb client ping but command no longer exists
2 participants