Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: Exclude testing and benchmark files from coverage #280

Conversation

shahzadlone
Copy link
Member

Ignores testing and benchmark files that don't need to included in the code coverage report.

@shahzadlone shahzadlone added the action/no-benchmark Skips the action that runs the benchmark. label Mar 8, 2022
@shahzadlone shahzadlone added this to the DefraDB v0.3 milestone Mar 8, 2022
@shahzadlone shahzadlone self-assigned this Mar 8, 2022
@shahzadlone shahzadlone linked an issue Mar 8, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #280 (c303cf5) into develop (2a32f05) will increase coverage by 4.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #280      +/-   ##
===========================================
+ Coverage    58.28%   62.37%   +4.09%     
===========================================
  Files          103       84      -19     
  Lines        10200     9245     -955     
===========================================
- Hits          5945     5767     -178     
+ Misses        3622     2871     -751     
+ Partials       633      607      -26     
Impacted Files Coverage Δ
bench/collection/utils.go
db/tests/utils.go
db/tests/query/commit/utils.go
db/tests/query/all_commits/utils.go
bench/storage/utils.go
db/tests/query/one_to_two_many/utils.go
db/tests/query/simple/utils.go
db/tests/query/one_to_one/utils.go
db/tests/mutation/inline_array/utils.go
db/tests/query/complex/utils.go
... and 9 more

@AndrewSisley
Copy link
Contributor

Looks good, cheers. Bit of a shame it excludes packages that have no tests still (e.g. CLI), but that is a problem for another day :)

@shahzadlone shahzadlone merged commit 82b9468 into develop Mar 8, 2022
@shahzadlone shahzadlone deleted the lone/i-170/tools/remove-bench-and-test-folders-from-code-coverage branch March 8, 2022 16:59
shahzadlone added a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/no-benchmark Skips the action that runs the benchmark.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add benchmark suite to codecov ignore list
2 participants