feat: Remove IsObjectArray #2859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
feature
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2859 +/- ##
===========================================
+ Coverage 79.38% 79.41% +0.03%
===========================================
Files 323 323
Lines 24693 24683 -10
===========================================
- Hits 19602 19601 -1
+ Misses 3687 3680 -7
+ Partials 1404 1402 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 14 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
nasdf
approved these changes
Jul 23, 2024
| ttype, ok = g.manager.schema.TypeMap()[field.Kind.Underlying()] | ||
| if !ok { | ||
| return nil, NewErrTypeNotFound(field.Kind.Underlying()) | ||
| } |
There was a problem hiding this comment.
nitpick: minor simplification
if field.Kind.IsObject() {
var ok bool
ttype, ok = g.manager.schema.TypeMap()[field.Kind.Underlying()]
if !ok {
return nil, NewErrTypeNotFound(field.Kind.Underlying())
}
if field.Kind.IsArray() {
ttype = gql.NewList(ttype)
}
}There was a problem hiding this comment.
Good spot, thanks :)
- generate.go simplification
AndrewSisley
force-pushed
the
2356-rm-is-object-array
branch
from
bd29b12
to
9cb75c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #2356
Description
Removes IsObjectArray.
As well as causing confused code, and an overly-large interface, where their are multiple overlapping ways to check the same thing, this func also dirties the solution for #2493 and #2619.
PR is marked as a feature as it is a public change, could be called 'fix', I think it is a bit vague here give me a shout if you have a strong preference.