Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add assert on DocIndex for child documents #2871

Merged
merged 3 commits into from
Jul 25, 2024

Conversation

islamaliev
Copy link
Contributor

Relevant issue(s)

Resolves #2870

Description

Enables asserting using testUsilts.NewDocIndex on child documents

@islamaliev islamaliev added the area/testing Related to any test or testing suite label Jul 24, 2024
@islamaliev islamaliev added this to the DefraDB v0.13 milestone Jul 24, 2024
@islamaliev islamaliev self-assigned this Jul 24, 2024
Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and looks simpler than I assumed it would be - thanks for this!

@islamaliev islamaliev changed the title tests: Add assert on DocIndex for child documents test: Add assert on DocIndex for child documents Jul 24, 2024
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.46%. Comparing base (cca14ac) to head (d42d06f).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2871      +/-   ##
===========================================
+ Coverage    79.36%   79.46%   +0.11%     
===========================================
  Files          323      323              
  Lines        24692    24692              
===========================================
+ Hits         19595    19621      +26     
+ Misses        3690     3673      -17     
+ Partials      1407     1398       -9     
Flag Coverage Δ
all-tests 79.46% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 20 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cca14ac...d42d06f. Read the comment docs.

@islamaliev islamaliev force-pushed the tests/assert-doc-index-for-child-docs branch from 7e190b9 to d42d06f Compare July 25, 2024 06:01
@islamaliev islamaliev merged commit 12b7624 into develop Jul 25, 2024
43 of 44 checks passed
@islamaliev islamaliev deleted the tests/assert-doc-index-for-child-docs branch July 25, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Related to any test or testing suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend testUtils.NewDocIndex to work on child documents
2 participants