Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Create mutation introspection #2881

Merged

Conversation

nasdf
Copy link
Member

@nasdf nasdf commented Jul 30, 2024

Relevant issue(s)

Resolves #2868

Description

This PR fixes the create mutation return type.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

manually tested in playground

Specify the platform(s) on which this was tested:

  • MacOS

@nasdf nasdf added the area/query Related to the query component label Jul 30, 2024
@nasdf nasdf added this to the DefraDB v0.13 milestone Jul 30, 2024
@nasdf nasdf self-assigned this Jul 30, 2024
@nasdf nasdf requested a review from a team July 30, 2024 20:13
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.43%. Comparing base (8bd255f) to head (0f30014).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2881      +/-   ##
===========================================
- Coverage    79.52%   79.43%   -0.10%     
===========================================
  Files          325      325              
  Lines        24778    24778              
===========================================
- Hits         19704    19680      -24     
- Misses        3668     3682      +14     
- Partials      1406     1416      +10     
Flag Coverage Δ
all-tests 79.43% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/request/graphql/schema/generate.go 87.95% <100.00%> (ø)

... and 14 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bd255f...0f30014. Read the comment docs.

Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice spot, thanks Keenan

@nasdf nasdf merged commit 6ad8f18 into sourcenetwork:develop Jul 30, 2024
41 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/query Related to the query component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create mutation introspection is incorrect
2 participants