Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests that tests blocks with multiple heads #2910

Open
islamaliev opened this issue Aug 14, 2024 · 0 comments
Open

Add tests that tests blocks with multiple heads #2910

islamaliev opened this issue Aug 14, 2024 · 0 comments
Labels
area/testing Related to any test or testing suite

Comments

@islamaliev
Copy link
Contributor

At the moment we don't have any test that tests merging a block with multiple heads. If we pick the first head all tests will pass.
The relevant code is in internal/db/merge.go in func (mp *mergeProcessor) loadBlocks.

This is sensitive and crucial part of defradb and should be properly tested.

This will be covered anyway once #2769 is in place, but it's encryption-related and we might want to have a separate test focused purely on this part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Related to any test or testing suite
Projects
None yet
Development

No branches or pull requests

1 participant