Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: No panic if filter condition on indexed field is empty #2929

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

islamaliev
Copy link
Contributor

Relevant issue(s)

Resolves #2916

Description

Check if given filter condition is empty before proceeding with secondary index fetching.

@islamaliev islamaliev added bug Something isn't working area/query Related to the query component labels Aug 19, 2024
@islamaliev islamaliev added this to the DefraDB v0.13 milestone Aug 19, 2024
@islamaliev islamaliev self-assigned this Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.47%. Comparing base (defb37a) to head (81dcca6).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2929      +/-   ##
===========================================
- Coverage    79.51%   79.47%   -0.03%     
===========================================
  Files          325      325              
  Lines        24778    24781       +3     
===========================================
- Hits         19700    19694       -6     
- Misses        3669     3675       +6     
- Partials      1409     1412       +3     
Flag Coverage Δ
all-tests 79.47% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/db/fetcher/indexer.go 85.71% <100.00%> (+2.83%) ⬆️
internal/db/fetcher/indexer_iterators.go 80.79% <100.00%> (+0.10%) ⬆️

... and 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update defb37a...81dcca6. Read the comment docs.

@islamaliev islamaliev requested a review from a team August 19, 2024 21:28
Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@islamaliev islamaliev merged commit 9422244 into develop Aug 20, 2024
43 of 45 checks passed
@islamaliev islamaliev deleted the fix/empty-filter-on-indexed-field branch August 20, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/query Related to the query component bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty filter condition on indexed field within top-level count panics
2 participants