-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enable indexing for DateTime fields #2933
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2933 +/- ##
===========================================
- Coverage 79.50% 79.33% -0.17%
===========================================
Files 325 326 +1
Lines 24781 24856 +75
===========================================
+ Hits 19701 19718 +17
- Misses 3670 3726 +56
- Partials 1410 1412 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 18 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks Islam :)
thought: I think (not in this PR) that the GQL code should change so that all field types are not supported by default, or we'll likely have this same issue in the future.
testUtils.CreateDoc{ | ||
Doc: `{ | ||
"name": "Fred", | ||
"birthday": "2000-07-23T03:00:00-00:00" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Damn... I'm so much younger than I thought. I love this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the fix.
Relevant issue(s)
Resolves #2914
Description
Make indexes handle time.Time type as well.
For this encoding/decoding of time type is added to encoding package.