fix: Add ns precision support to time values #2940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2940 +/- ##
===========================================
+ Coverage 79.30% 79.37% +0.08%
===========================================
Files 326 326
Lines 24856 24860 +4
===========================================
+ Hits 19710 19732 +22
+ Misses 3731 3720 -11
+ Partials 1415 1408 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Was previously only second precision, which is not particularly useful for many applications (such as createdAt timestamps used to allow multiple similar documents to be created within the same second).
AndrewSisley
force-pushed
the
2927-datetime-ms
branch
from
acb046b
to
0c8e4d9
Compare
fredcarle
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #2927
Description
Add nanosecond precision support to time values.
Was previously only second precision, which is not particularly useful for many applications (such as createdAt timestamps used to allow multiple similar documents to be created within the same second).