Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle index queries where child found without parent #2942

Merged

Conversation

AndrewSisley
Copy link
Contributor

Relevant issue(s)

Resolves #2925

Description

Handles secondary index queries where child found without parent.

Previously the new test would panic further up the callstack (to the prod change), as the parent doc would be nil minus the joined property.

@AndrewSisley AndrewSisley added bug Something isn't working area/query Related to the query component labels Aug 21, 2024
@AndrewSisley AndrewSisley added this to the DefraDB v0.13 milestone Aug 21, 2024
@AndrewSisley AndrewSisley requested a review from a team August 21, 2024 20:25
@AndrewSisley AndrewSisley self-assigned this Aug 21, 2024
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.27%. Comparing base (a4029a9) to head (531096d).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2942      +/-   ##
===========================================
- Coverage    79.33%   79.27%   -0.05%     
===========================================
  Files          326      326              
  Lines        24860    24862       +2     
===========================================
- Hits         19721    19709      -12     
- Misses        3728     3737       +9     
- Partials      1411     1416       +5     
Flag Coverage Δ
all-tests 79.27% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/planner/type_join.go 81.33% <100.00%> (+0.09%) ⬆️

... and 17 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4029a9...531096d. Read the comment docs.

Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AndrewSisley AndrewSisley merged commit 53e55c4 into sourcenetwork:develop Aug 22, 2024
42 of 43 checks passed
@AndrewSisley AndrewSisley deleted the 2925-top-level-filter-panic branch August 22, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/query Related to the query component bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Index panics when child has record and parent does not
2 participants