Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Add commits lost during github outage #303

Merged
merged 2 commits into from
Mar 17, 2022
Merged

refactor: Add commits lost during github outage #303

merged 2 commits into from
Mar 17, 2022

Conversation

AndrewSisley
Copy link
Contributor

Part of #200

@AndrewSisley AndrewSisley added the refactor This issue specific to or requires *notable* refactoring of existing codebases and components label Mar 17, 2022
@AndrewSisley AndrewSisley self-assigned this Mar 17, 2022
@codecov
Copy link

codecov bot commented Mar 17, 2022 •
edited
Loading

Codecov Report

Merging #303 (6569d28) into develop (d40a3cc) will not change coverage.
The diff coverage is 79.48%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #303   +/-   ##
========================================
  Coverage    65.07%   65.07%           
========================================
  Files           80       80           
  Lines         8979     8979           
========================================
  Hits          5843     5843           
  Misses        2520     2520           
  Partials       616      616
Impacted Files Coverage Δ
client/descriptions.go 90.00% <ø> (ø)
query/graphql/schema/relations.go 62.37% <74.19%> (ø)
query/graphql/planner/type_join.go 68.01% <100.00%> (ø)
query/graphql/schema/descriptions.go 86.13% <100.00%> (ø)
query/graphql/schema/generate.go 81.51% <100.00%> (ø)

@AndrewSisley AndrewSisley merged commit 42721cb into develop Mar 17, 2022
@AndrewSisley AndrewSisley deleted the sisley/refactor/I200-mv-descriptions branch March 17, 2022 17:55
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@AndrewSisley
refactor: Add commits lost during github outage (sourcenetwork#303)
30a2f81 
* Rename Field.Meta to RelationshipType

* Rename RelationType consts to match new type name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzadlone shahzadlone shahzadlone approved these changes

@orpheuslummis orpheuslummis Awaiting requested review from orpheuslummis

@jsimnz jsimnz Awaiting requested review from jsimnz

Assignees

@AndrewSisley AndrewSisley

Labels
refactor This issue specific to or requires *notable* refactoring of existing codebases and components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndrewSisley @shahzadlone