-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add test for deletion of records in a relationship #329
Merged
shahzadlone
merged 3 commits into
develop
from
lone/test/i-221-add-test-for-deletion-of-records-in-a-relationship
Apr 18, 2022
Merged
test: Add test for deletion of records in a relationship #329
shahzadlone
merged 3 commits into
develop
from
lone/test/i-221-add-test-for-deletion-of-records-in-a-relationship
Apr 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
reviewed
Apr 5, 2022
@@ -0,0 +1,20 @@ | |||
## Testing Guide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Readme looks good - cheers for adding this!
shahzadlone
force-pushed
the
lone/test/i-221-add-test-for-deletion-of-records-in-a-relationship
branch
from
April 5, 2022 18:09
ac4110d
to
ce7b820
Compare
orpheuslummis
approved these changes
Apr 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
shahzadlone
force-pushed
the
lone/test/i-221-add-test-for-deletion-of-records-in-a-relationship
branch
from
April 5, 2022 20:38
ce7b820
to
f3446fa
Compare
shahzadlone
added
action/no-benchmark
Skips the action that runs the benchmark.
area/testing
Related to any test or testing suite
labels
Apr 5, 2022
Benchmark ResultsSummary
✅ See Better Results...
❌ See Worse Results...
✨ See Unchanged Results...
🐋 See Full Results...
|
Merge #333 before this to avoid looking at a |
shahzadlone
force-pushed
the
lone/test/i-221-add-test-for-deletion-of-records-in-a-relationship
branch
from
April 18, 2022 05:46
f3446fa
to
4a6142d
Compare
shahzadlone
force-pushed
the
lone/test/i-221-add-test-for-deletion-of-records-in-a-relationship
branch
from
April 18, 2022 06:58
4a6142d
to
f33fbd6
Compare
shahzadlone
deleted the
lone/test/i-221-add-test-for-deletion-of-records-in-a-relationship
branch
April 18, 2022 07:19
shahzadlone
added a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
…rk#329) resolves sourcenetwork#221 These are non-transactional tests. Should have some transactional tests too (@todo sourcenetwork#328).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
action/no-benchmark
Skips the action that runs the benchmark.
area/testing
Related to any test or testing suite
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #221
These are non-transactional tests.
Should have some transactional tests too (@todo #328).