Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Update golang-ci linter and explicit go-setup to use v1.17 #331

Merged
merged 4 commits into from
Apr 5, 2022
Merged

ci: Update golang-ci linter and explicit go-setup to use v1.17 #331

merged 4 commits into from
Apr 5, 2022

Conversation

shahzadlone
Copy link
Member

Resolves #330

@shahzadlone shahzadlone added the ci/build This is issue is about the build or CI system, and the administration of it. label Apr 5, 2022
@shahzadlone shahzadlone added this to the DefraDB v0.3 milestone Apr 5, 2022
@shahzadlone shahzadlone self-assigned this Apr 5, 2022
@source-devs

This comment was marked as duplicate.

Sign in to view
@shahzadlone shahzadlone changed the title ci: Fix broken linter ci: Update golang-ci linter and explicit go-setup to use v1.17 Apr 5, 2022
@source-devs

This comment was marked as off-topic.

Sign in to view
@orpheuslummis
Copy link
Contributor

orpheuslummis commented Apr 5, 2022 •
edited
Loading

113 Benchmarks successfully compared.
113 Benchmarks were ✅ Better.
0 Benchmarks were ❌ Worse .

I thought that was funny.

orpheuslummis
orpheuslummis reviewed Apr 5, 2022
View reviewed changes
Makefile Show resolved Hide resolved
@shahzadlone shahzadlone added the action/no-benchmark Skips the action that runs the benchmark. label Apr 5, 2022
orpheuslummis
orpheuslummis approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@orpheuslummis orpheuslummis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM provided the experiment works. Hopefully the future golangci-lint versions will be backwards compatible.

@shahzadlone shahzadlone merged commit 6f56272 into develop Apr 5, 2022
@shahzadlone shahzadlone deleted the lone/fix-linter branch April 5, 2022 20:37
shahzadlone added a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@shahzadlone
ci: Update golang-ci linter and explicit go-setup to use v1.17 (sourc…
a870b48 
…enetwork#331)

* Bump to latest golangci version.

* Bump `checkout`, `go-setup`, `golangci` and `golangci-action`

* Setup go environment right before the linter is ran.

* Bump other `checkout`(s) and also omit the patch version in `y.x.0` and
set `check-latest: true`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orpheuslummis orpheuslummis orpheuslummis approved these changes

@jsimnz jsimnz Awaiting requested review from jsimnz

@AndrewSisley AndrewSisley Awaiting requested review from AndrewSisley

Assignees

@shahzadlone shahzadlone

Labels
action/no-benchmark Skips the action that runs the benchmark. ci/build This is issue is about the build or CI system, and the administration of it.
Projects
None yet
Milestone
DefraDB v0.3
Development

Successfully merging this pull request may close these issues.

Fix broken golang-ci linter
3 participants
@shahzadlone @source-devs @orpheuslummis