Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: Add linter rule for copyright headers #360

Merged
merged 2 commits into from
Apr 21, 2022
Merged

tools: Add linter rule for copyright headers #360

merged 2 commits into from
Apr 21, 2022

Conversation

shahzadlone
Copy link
Member

ISSUE

This should resolve #148.

DESCRIPTION

Excludes:

  • Everything under the net folder is ignored
  • The file datastore/badger/v3/compat_logger.go is ignored because it has copied code.
  • The file datastore/badger/v3/datastore.go is ignored because it has copied code.

@shahzadlone shahzadlone added the action/no-benchmark Skips the action that runs the benchmark. label Apr 19, 2022
@shahzadlone shahzadlone added this to the DefraDB v0.3 milestone Apr 19, 2022
@shahzadlone shahzadlone self-assigned this Apr 19, 2022
@source-devs
Copy link

Benchmark Results

Summary

  • 113 Benchmarks successfully compared.
  • 9 Benchmarks were ✅ Better.
  • 104 Benchmarks were ❌ Worse .
  • 0 Benchmarks were ✨ Unchanged.
✅ See Better Results...
time/opdelta
_Query_UserSimple_Query_Sync_1000-49.40ms ± 0%9.20ms ± 0%−2.06%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_1000-4629µs ± 0%628µs ± 0%−0.29%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:1024-419.2µs ± 0%19.2µs ± 0%−0.14%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:1024-4192µs ± 0%190µs ± 0%−1.47%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0512-4157µs ± 0%155µs ± 0%−1.20%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0064-444.7µs ± 0%43.6µs ± 0%−2.57%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0512-453.0µs ± 0%52.3µs ± 0%−1.37%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:1024-415.0µs ± 0%14.7µs ± 0%−1.63%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0512-41.19ms ± 0%1.18ms ± 0%−0.67%(p=1.000 n=1+1)
 
❌ See Worse Results...
time/opdelta
_Collection_UserSimple_CreateMany_Sync_0_100-4208ms ± 0%224ms ± 0%+7.79%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_10-49.27ms ± 0%9.76ms ± 0%+5.25%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_100-493.8ms ± 0%97.4ms ± 0%+3.84%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_1000-4963ms ± 0%988ms ± 0%+2.58%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_100-441.9ms ± 0%44.6ms ± 0%+6.33%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_1000-4415ms ± 0%429ms ± 0%+3.44%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_10000-44.31s ± 0%4.45s ± 0%+3.24%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_10_10-4317µs ± 0%331µs ± 0%+4.55%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_100_100-43.40ms ± 0%3.49ms ± 0%+2.75%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_1000-437.0ms ± 0%37.4ms ± 0%+1.05%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_10-4340µs ± 0%362µs ± 0%+6.52%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_100-43.55ms ± 0%3.68ms ± 0%+3.53%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_10_10-4238µs ± 0%255µs ± 0%+6.95%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_100_100-41.71ms ± 0%1.81ms ± 0%+5.35%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_1000-422.4ms ± 0%24.3ms ± 0%+8.21%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_10-4249µs ± 0%253µs ± 0%+1.41%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_100-41.81ms ± 0%1.81ms ± 0%+0.10%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_100-41.10ms ± 0%1.14ms ± 0%+3.40%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_10-4406µs ± 0%424µs ± 0%+4.52%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_100-41.21ms ± 0%1.23ms ± 0%+1.87%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_1000-49.56ms ± 0%9.84ms ± 0%+2.92%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_10-4367µs ± 0%376µs ± 0%+2.35%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_100-4416µs ± 0%428µs ± 0%+2.77%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_1000-4419µs ± 0%423µs ± 0%+0.95%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_10-4617µs ± 0%621µs ± 0%+0.76%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_100-4600µs ± 0%618µs ± 0%+3.05%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_10-4260µs ± 0%275µs ± 0%+5.72%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_100-4262µs ± 0%267µs ± 0%+1.97%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_1000-4264µs ± 0%270µs ± 0%+2.27%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_10-4384µs ± 0%398µs ± 0%+3.50%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_100-41.30ms ± 0%1.35ms ± 0%+3.25%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_1000-411.8ms ± 0%12.2ms ± 0%+3.63%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0128-412.8µs ± 0%12.9µs ± 0%+1.05%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0256-413.6µs ± 0%13.9µs ± 0%+2.29%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0512-415.1µs ± 0%15.1µs ± 0%+0.01%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0064-4118µs ± 0%133µs ± 0%+12.26%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0128-4125µs ± 0%131µs ± 0%+4.74%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0256-4133µs ± 0%141µs ± 0%+6.29%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0512-4151µs ± 0%154µs ± 0%+2.11%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0064-414.2µs ± 0%14.9µs ± 0%+5.41%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0128-414.4µs ± 0%18.0µs ± 0%+24.54%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0256-415.0µs ± 0%15.6µs ± 0%+3.58%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0512-416.8µs ± 0%18.1µs ± 0%+7.34%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:1024-420.4µs ± 0%21.8µs ± 0%+6.41%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0064-4131µs ± 0%148µs ± 0%+12.92%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0128-4136µs ± 0%141µs ± 0%+3.70%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0256-4142µs ± 0%157µs ± 0%+10.31%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:1024-4196µs ± 0%197µs ± 0%+0.26%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0128-444.1µs ± 0%47.3µs ± 0%+7.26%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0256-445.6µs ± 0%47.8µs ± 0%+4.81%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:1024-464.3µs ± 0%66.4µs ± 0%+3.23%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0064-4325µs ± 0%363µs ± 0%+11.55%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0128-4334µs ± 0%365µs ± 0%+9.35%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0256-4348µs ± 0%373µs ± 0%+7.04%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0512-4377µs ± 0%404µs ± 0%+7.13%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:1024-4467µs ± 0%499µs ± 0%+6.84%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0064-443.2µs ± 0%50.6µs ± 0%+17.00%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0128-443.0µs ± 0%49.2µs ± 0%+14.48%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0256-445.0µs ± 0%53.3µs ± 0%+18.57%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0512-451.1µs ± 0%55.2µs ± 0%+8.07%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:1024-463.4µs ± 0%66.7µs ± 0%+5.24%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0064-4328µs ± 0%379µs ± 0%+15.54%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0128-4342µs ± 0%362µs ± 0%+5.79%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0256-4362µs ± 0%371µs ± 0%+2.47%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0512-4391µs ± 0%407µs ± 0%+4.08%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:1024-4476µs ± 0%495µs ± 0%+3.95%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0064-4115µs ± 0%118µs ± 0%+2.68%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0128-4114µs ± 0%122µs ± 0%+7.23%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0256-4118µs ± 0%127µs ± 0%+7.41%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0512-4120µs ± 0%132µs ± 0%+10.11%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:1024-4133µs ± 0%143µs ± 0%+7.76%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0064-41.14ms ± 0%1.38ms ± 0%+20.80%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0128-41.14ms ± 0%1.33ms ± 0%+15.77%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0256-41.16ms ± 0%1.51ms ± 0%+30.76%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0512-41.22ms ± 0%1.44ms ± 0%+17.89%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:1024-41.33ms ± 0%1.57ms ± 0%+17.79%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0064-4106µs ± 0%117µs ± 0%+9.80%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0128-4109µs ± 0%121µs ± 0%+11.65%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0256-4110µs ± 0%129µs ± 0%+17.46%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0512-4114µs ± 0%129µs ± 0%+13.71%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:1024-4131µs ± 0%135µs ± 0%+2.78%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0064-41.09ms ± 0%1.14ms ± 0%+4.63%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0128-41.09ms ± 0%1.17ms ± 0%+7.06%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0256-41.13ms ± 0%1.20ms ± 0%+7.01%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0512-41.16ms ± 0%1.25ms ± 0%+8.55%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:1024-41.28ms ± 0%1.42ms ± 0%+11.00%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0064-48.20µs ± 0%8.36µs ± 0%+1.93%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0128-48.31µs ± 0%9.73µs ± 0%+16.97%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0256-49.34µs ± 0%9.68µs ± 0%+3.62%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0512-410.7µs ± 0%11.4µs ± 0%+6.85%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0064-485.4µs ± 0%95.3µs ± 0%+11.64%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0128-483.7µs ± 0%104.4µs ± 0%+24.65%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0256-496.2µs ± 0%106.4µs ± 0%+10.62%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0512-4111µs ± 0%126µs ± 0%+13.27%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:1024-4150µs ± 0%152µs ± 0%+1.32%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0064-4115µs ± 0%116µs ± 0%+0.45%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0128-4116µs ± 0%120µs ± 0%+3.47%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0256-4118µs ± 0%121µs ± 0%+2.29%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0512-4120µs ± 0%122µs ± 0%+1.34%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:1024-4124µs ± 0%126µs ± 0%+2.05%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0064-41.19ms ± 0%1.20ms ± 0%+0.50%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0128-41.18ms ± 0%1.21ms ± 0%+2.57%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0256-41.16ms ± 0%1.22ms ± 0%+5.57%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:1024-41.26ms ± 0%1.26ms ± 0%+0.17%(p=1.000 n=1+1)
 
✨ See Unchanged Results...
time/opdelta
 
🐋 See Full Results...
develop.txtcurrent.txt
time/opdelta
pkg:github.com/sourcenetwork/defradb/bench/collection goos:linux goarch:amd64
_Collection_UserSimple_CreateMany_Sync_0_10-410.1ms ± 0%10.9ms ± 0%+8.44%(p=1.000 n=1+1)
_Collection_UserSimple_CreateMany_Sync_0_100-4208ms ± 0%224ms ± 0%+7.79%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_10-49.27ms ± 0%9.76ms ± 0%+5.25%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_100-493.8ms ± 0%97.4ms ± 0%+3.84%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_1000-4963ms ± 0%988ms ± 0%+2.58%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_100-441.9ms ± 0%44.6ms ± 0%+6.33%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_1000-4415ms ± 0%429ms ± 0%+3.44%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_10000-44.31s ± 0%4.45s ± 0%+3.24%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_10_10-4317µs ± 0%331µs ± 0%+4.55%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_100_100-43.40ms ± 0%3.49ms ± 0%+2.75%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_1000-437.0ms ± 0%37.4ms ± 0%+1.05%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_10-4340µs ± 0%362µs ± 0%+6.52%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_100-43.55ms ± 0%3.68ms ± 0%+3.53%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_10_10-4238µs ± 0%255µs ± 0%+6.95%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_100_100-41.71ms ± 0%1.81ms ± 0%+5.35%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_1000-422.4ms ± 0%24.3ms ± 0%+8.21%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_10-4249µs ± 0%253µs ± 0%+1.41%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_100-41.81ms ± 0%1.81ms ± 0%+0.10%(p=1.000 n=1+1)
pkg:github.com/sourcenetwork/defradb/bench/query/simple goos:linux goarch:amd64
_Query_UserSimple_Query_Sync_10-4327µs ± 0%334µs ± 0%+2.04%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_100-41.10ms ± 0%1.14ms ± 0%+3.40%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_1000-49.40ms ± 0%9.20ms ± 0%−2.06%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_10-4406µs ± 0%424µs ± 0%+4.52%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_100-41.21ms ± 0%1.23ms ± 0%+1.87%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_1000-49.56ms ± 0%9.84ms ± 0%+2.92%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_10-4367µs ± 0%376µs ± 0%+2.35%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_100-4416µs ± 0%428µs ± 0%+2.77%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_1000-4419µs ± 0%423µs ± 0%+0.95%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_10-4617µs ± 0%621µs ± 0%+0.76%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_100-4600µs ± 0%618µs ± 0%+3.05%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_1000-4629µs ± 0%628µs ± 0%−0.29%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_10-4260µs ± 0%275µs ± 0%+5.72%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_100-4262µs ± 0%267µs ± 0%+1.97%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_1000-4264µs ± 0%270µs ± 0%+2.27%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_10-4384µs ± 0%398µs ± 0%+3.50%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_100-41.30ms ± 0%1.35ms ± 0%+3.25%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_1000-411.8ms ± 0%12.2ms ± 0%+3.63%(p=1.000 n=1+1)
pkg:github.com/sourcenetwork/defradb/bench/storage goos:linux goarch:amd64
_Storage_Simple_Read_Sync_1_10/ValueSize:0064-411.8µs ± 0%12.8µs ± 0%+8.36%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0128-412.8µs ± 0%12.9µs ± 0%+1.05%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0256-413.6µs ± 0%13.9µs ± 0%+2.29%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0512-415.1µs ± 0%15.1µs ± 0%+0.01%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:1024-419.2µs ± 0%19.2µs ± 0%−0.14%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0064-4118µs ± 0%133µs ± 0%+12.26%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0128-4125µs ± 0%131µs ± 0%+4.74%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0256-4133µs ± 0%141µs ± 0%+6.29%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0512-4151µs ± 0%154µs ± 0%+2.11%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:1024-4192µs ± 0%190µs ± 0%−1.47%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0064-414.2µs ± 0%14.9µs ± 0%+5.41%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0128-414.4µs ± 0%18.0µs ± 0%+24.54%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0256-415.0µs ± 0%15.6µs ± 0%+3.58%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0512-416.8µs ± 0%18.1µs ± 0%+7.34%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:1024-420.4µs ± 0%21.8µs ± 0%+6.41%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0064-4131µs ± 0%148µs ± 0%+12.92%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0128-4136µs ± 0%141µs ± 0%+3.70%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0256-4142µs ± 0%157µs ± 0%+10.31%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0512-4157µs ± 0%155µs ± 0%−1.20%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:1024-4196µs ± 0%197µs ± 0%+0.26%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0064-444.7µs ± 0%43.6µs ± 0%−2.57%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0128-444.1µs ± 0%47.3µs ± 0%+7.26%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0256-445.6µs ± 0%47.8µs ± 0%+4.81%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0512-453.0µs ± 0%52.3µs ± 0%−1.37%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:1024-464.3µs ± 0%66.4µs ± 0%+3.23%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0064-4325µs ± 0%363µs ± 0%+11.55%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0128-4334µs ± 0%365µs ± 0%+9.35%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0256-4348µs ± 0%373µs ± 0%+7.04%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0512-4377µs ± 0%404µs ± 0%+7.13%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:1024-4467µs ± 0%499µs ± 0%+6.84%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0064-443.2µs ± 0%50.6µs ± 0%+17.00%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0128-443.0µs ± 0%49.2µs ± 0%+14.48%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0256-445.0µs ± 0%53.3µs ± 0%+18.57%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0512-451.1µs ± 0%55.2µs ± 0%+8.07%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:1024-463.4µs ± 0%66.7µs ± 0%+5.24%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0064-4328µs ± 0%379µs ± 0%+15.54%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0128-4342µs ± 0%362µs ± 0%+5.79%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0256-4362µs ± 0%371µs ± 0%+2.47%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0512-4391µs ± 0%407µs ± 0%+4.08%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:1024-4476µs ± 0%495µs ± 0%+3.95%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0064-4115µs ± 0%118µs ± 0%+2.68%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0128-4114µs ± 0%122µs ± 0%+7.23%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0256-4118µs ± 0%127µs ± 0%+7.41%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0512-4120µs ± 0%132µs ± 0%+10.11%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:1024-4133µs ± 0%143µs ± 0%+7.76%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0064-41.14ms ± 0%1.38ms ± 0%+20.80%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0128-41.14ms ± 0%1.33ms ± 0%+15.77%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0256-41.16ms ± 0%1.51ms ± 0%+30.76%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0512-41.22ms ± 0%1.44ms ± 0%+17.89%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:1024-41.33ms ± 0%1.57ms ± 0%+17.79%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0064-4106µs ± 0%117µs ± 0%+9.80%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0128-4109µs ± 0%121µs ± 0%+11.65%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0256-4110µs ± 0%129µs ± 0%+17.46%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0512-4114µs ± 0%129µs ± 0%+13.71%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:1024-4131µs ± 0%135µs ± 0%+2.78%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0064-41.09ms ± 0%1.14ms ± 0%+4.63%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0128-41.09ms ± 0%1.17ms ± 0%+7.06%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0256-41.13ms ± 0%1.20ms ± 0%+7.01%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0512-41.16ms ± 0%1.25ms ± 0%+8.55%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:1024-41.28ms ± 0%1.42ms ± 0%+11.00%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0064-48.20µs ± 0%8.36µs ± 0%+1.93%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0128-48.31µs ± 0%9.73µs ± 0%+16.97%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0256-49.34µs ± 0%9.68µs ± 0%+3.62%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0512-410.7µs ± 0%11.4µs ± 0%+6.85%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:1024-415.0µs ± 0%14.7µs ± 0%−1.63%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0064-485.4µs ± 0%95.3µs ± 0%+11.64%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0128-483.7µs ± 0%104.4µs ± 0%+24.65%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0256-496.2µs ± 0%106.4µs ± 0%+10.62%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0512-4111µs ± 0%126µs ± 0%+13.27%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:1024-4150µs ± 0%152µs ± 0%+1.32%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0064-4115µs ± 0%116µs ± 0%+0.45%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0128-4116µs ± 0%120µs ± 0%+3.47%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0256-4118µs ± 0%121µs ± 0%+2.29%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0512-4120µs ± 0%122µs ± 0%+1.34%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:1024-4124µs ± 0%126µs ± 0%+2.05%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0064-41.19ms ± 0%1.20ms ± 0%+0.50%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0128-41.18ms ± 0%1.21ms ± 0%+2.57%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0256-41.16ms ± 0%1.22ms ± 0%+5.57%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0512-41.19ms ± 0%1.18ms ± 0%−0.67%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:1024-41.26ms ± 0%1.26ms ± 0%+0.17%(p=1.000 n=1+1)
 

shahzadlone
shahzadlone commented Apr 19, 2022
View reviewed changes
net/doc.go Show resolved Hide resolved
tools/configs/golangci.yaml Show resolved Hide resolved
@shahzadlone shahzadlone mentioned this pull request Apr 20, 2022
Closed
orpheuslummis
orpheuslummis approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@orpheuslummis orpheuslummis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, after comments are resolved ... and is rebased with new develop ?

jsimnz
jsimnz approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@jsimnz jsimnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahzadlone shahzadlone force-pushed the lone/i-148/add-goheader-lint-rule branch from 203c492 to d832f29 Compare April 21, 2022 12:22
@shahzadlone shahzadlone changed the title tools: Add linter rule for copyright heading tools: Add linter rule for copyright headers Apr 21, 2022
@shahzadlone shahzadlone merged commit f1329ec into develop Apr 21, 2022
@shahzadlone shahzadlone deleted the lone/i-148/add-goheader-lint-rule branch April 21, 2022 19:13
shahzadlone added a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@shahzadlone
tools: Add linter rule for copyright headers (sourcenetwork#360)
c0c3598 
Resolve sourcenetwork#148.


Excludes / Ignores:
Everything under the net folder.
The file datastore/badger/v3/compat_logger.go (is ignored because it has copied code).
The file datastore/badger/v3/datastore.go (is ignored because it has copied code).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsimnz jsimnz jsimnz approved these changes

@orpheuslummis orpheuslummis orpheuslummis approved these changes

@AndrewSisley AndrewSisley Awaiting requested review from AndrewSisley

Assignees

@shahzadlone shahzadlone

Labels
action/no-benchmark Skips the action that runs the benchmark.
Projects
None yet
Milestone
DefraDB v0.3
Development

Successfully merging this pull request may close these issues.

Business Source License to be used in CI linting
4 participants
@shahzadlone @source-devs @orpheuslummis @jsimnz